From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CEF6C67861 for ; Sat, 6 Apr 2024 15:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zUIQ6SWpFRZREP+SCZCAedRjt4fpjLiVwrh5UpjkmVU=; b=3oiPCMBeIddQvV +PEHGNq0RfFatpdzD7QxRR3sJdZHuM/8YLbTHB0/uXDRZ+wHQdSKv5eQpyuPVZQF8VmS9WoiXwljG 6ZOdUN5uKGli4yYW5UIeo3Im9JkpKO8kRyS/dLvaaMoaN+/6Ws4u27xjs8pWQQmEpunvbeGIjNOA1 WhMiLD2FUm5NwJDKA+AjcuUNP5ns86r9v4iqhNf9STOS/LBIBw6wM7gtwEZn5R02NobrkEIHcGNM9 obCXybi4a2Zd5r9PVzgP0IjYHXgyOtvDaFDMpmSIW1SeIezjusHVjh1Dg7MZvtaUdxrMPpNCmmxA/ TD2hKgTHG3zVBSFCz62w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt8RQ-0000000AaBn-44vJ; Sat, 06 Apr 2024 15:58:52 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt8RO-0000000AaBB-0qMA for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 15:58:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=j4wsuCXSqn6uoRNQn7YbhCaXFnmRpqFl6kS8zFaXYgg=; b=fuKZqE5r+3JLdPKZBwuyf5obJq 623AkBjqhSEu5NSgQRxygFKrQ7bklm/amGQR5jL+rr+DcaNnZxMMurdjPtZ7hBfG4TtpTCOnAfPqN +TuulBU7RRg0GBDvKN6Au9tHNM5SSjSLGn3v2QLJtQQT2kq4gBwezDEbxKHFh/EDni8E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rt8RF-00CNV6-SB; Sat, 06 Apr 2024 17:58:41 +0200 Date: Sat, 6 Apr 2024 17:58:41 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?iso-8859-1?Q?K=F6ry?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?iso-8859-1?Q?Beh=FAn?= , Piergiorgio Beruto , Oleksij Rempel , =?iso-8859-1?Q?Nicol=F2?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v11 07/13] net: ethtool: Introduce a command to list PHYs on an interface Message-ID: References: <20240404093004.2552221-1-maxime.chevallier@bootlin.com> <20240404093004.2552221-8-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240404093004.2552221-8-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_085850_266124_E8D862F9 X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 11:29:57AM +0200, Maxime Chevallier wrote: > As we have the ability to track the PHYs connected to a net_device > through the link_topology, we can expose this list to userspace. This > allows userspace to use these identifiers for phy-specific commands and > take the decision of which PHY to target by knowing the link topology. > > Add PHY_GET and PHY_DUMP, which can be a filtered DUMP operation to list > devices on only one interface. > > Signed-off-by: Maxime Chevallier It would be good if Jakub reviewed this as well, since i don't know netlink too well. But: Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D77D38396; Sat, 6 Apr 2024 15:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712419126; cv=none; b=T6CUFoHLgIjs1DvJ2uyc8LG5H0xI10PhOvh+lcuHeI2ZFSvXV1RmD9/SDi1nU/I8EiBKxjBdD9aCgifoJwO0etZ+DiJgFdh0fH0pgWS4wygxot7H1Y2flTLemSyUgvTwi9GEY38lRpK3xPzil8k1G1AtHwzRBc3lIKJ50TfJ/vA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712419126; c=relaxed/simple; bh=nNdKTO1hqqrwsAK7J5UWvHyMQWy/DPFAecbNqFDFKx4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O8KZTHLlNgLAhNUwWNj++j03ek7noizh3AwFSbRWNaMhDN7XFVzYmXnq2RV0lkTJUGUpTkl3VTkxpNebIG8FgPVKJ2mNGPMryfJLUcPea8gDC3vvSvNuuEHm1pxhYd6grXeNNEkJ8BsrTJ9dz3wr7QrN0N+sGY8Jryf4FJldL9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=fuKZqE5r; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="fuKZqE5r" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=j4wsuCXSqn6uoRNQn7YbhCaXFnmRpqFl6kS8zFaXYgg=; b=fuKZqE5r+3JLdPKZBwuyf5obJq 623AkBjqhSEu5NSgQRxygFKrQ7bklm/amGQR5jL+rr+DcaNnZxMMurdjPtZ7hBfG4TtpTCOnAfPqN +TuulBU7RRg0GBDvKN6Au9tHNM5SSjSLGn3v2QLJtQQT2kq4gBwezDEbxKHFh/EDni8E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rt8RF-00CNV6-SB; Sat, 06 Apr 2024 17:58:41 +0200 Date: Sat, 6 Apr 2024 17:58:41 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?iso-8859-1?Q?K=F6ry?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?iso-8859-1?Q?Beh=FAn?= , Piergiorgio Beruto , Oleksij Rempel , =?iso-8859-1?Q?Nicol=F2?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v11 07/13] net: ethtool: Introduce a command to list PHYs on an interface Message-ID: References: <20240404093004.2552221-1-maxime.chevallier@bootlin.com> <20240404093004.2552221-8-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404093004.2552221-8-maxime.chevallier@bootlin.com> On Thu, Apr 04, 2024 at 11:29:57AM +0200, Maxime Chevallier wrote: > As we have the ability to track the PHYs connected to a net_device > through the link_topology, we can expose this list to userspace. This > allows userspace to use these identifiers for phy-specific commands and > take the decision of which PHY to target by knowing the link topology. > > Add PHY_GET and PHY_DUMP, which can be a filtered DUMP operation to list > devices on only one interface. > > Signed-off-by: Maxime Chevallier It would be good if Jakub reviewed this as well, since i don't know netlink too well. But: Reviewed-by: Andrew Lunn Andrew