From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client
Date: Tue, 27 Sep 2016 13:35:56 +0100 [thread overview]
Message-ID: <a5ebe463-11ce-4675-ac3a-8d3f044f0d10@linux.intel.com> (raw)
In-Reply-To: <20160927121915.GU28107@nuc-i3427.alporthouse.com>
On 27/09/2016 13:19, Chris Wilson wrote:
> On Tue, Sep 27, 2016 at 01:07:13PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Several things we can clean up in this function:
>>
>> * Request and file passed in cannot be NULL. There is
>> a single caller which makes it impossible so change
>> that condition to a GEM_BUG_ON instead of a WARN
>> with a return code.
> And move it next to the single caller since this is a specialised
> function that is tied to userspace batches.
I thought about it, so OK, will do that.
> And the spinlock here is superfluous.
Hm why? There are places which iterate the list.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-27 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 12:07 [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client Tvrtko Ursulin
2016-09-27 12:19 ` Chris Wilson
2016-09-27 12:35 ` Tvrtko Ursulin [this message]
2016-09-27 12:49 ` ✓ Fi.CI.BAT: success for " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-09-27 9:44 [PATCH] " Tvrtko Ursulin
2016-09-28 13:25 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ebe463-11ce-4675-ac3a-8d3f044f0d10@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.