From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D28C433F5 for ; Wed, 30 Mar 2022 20:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232177AbiC3UXY (ORCPT ); Wed, 30 Mar 2022 16:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbiC3UXY (ORCPT ); Wed, 30 Mar 2022 16:23:24 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A6B3BA5F for ; Wed, 30 Mar 2022 13:21:38 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id r2so26125484iod.9 for ; Wed, 30 Mar 2022 13:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4qH3sjnyZ0sZu4IU936XgcnySyKMmLOeeiMCINTicno=; b=ZJ+jUXzm23avbF4K9SMxVMSicBNjPYuCYIOA/vgGY7WcSGsJmLUM1ErMcEtaeIqcv2 5PmOQQlBL8qzz8DbV5/asR0cLg/3usp6ksXP577st28dW3h7SBsNIq+vGM4/nYGH8it0 zL1k7aFl+eIzbY3dTkkPFhg5YzRjNGvcKUoI5M7oMzowN22RQU+WhikR92H9JGIEn70t B7w4iP61DZeYtxEg1oHF3lT6Iir4HpuolHxffRhYmYEbDRG1kl6fI2ONcslYOiXS451N YRiIVOjligELpykhgcE05vEvBVNbwEM6j4d50Kx9I2z9kYSlVqU7b0pOma+LAgGVvEqf o7/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4qH3sjnyZ0sZu4IU936XgcnySyKMmLOeeiMCINTicno=; b=m2qu/X2QkPvsm3yebuO23wkDGeGyXBXrk9ZU4j6r3OUBedKU+MyuDZ3s3/LM/qf83p krFkgSJSz6NAUyQqbJWDEuvVAOh9OF9zQY7XdaJ9r+El3cG5NAj1QAGGFS/NrM3SJp89 YbA9nT6yl/9CwwJ11heNBnTkk9TxROntL2TJtverC3W8X2TLigu/z8VynNn1TcAlFwXN wLlotAGv4iJiAljoN3rsujMvCEj8xD4IAa/bIZxhUKmA8rQBsB7JwO+rADf7KivGO7yu WFPql7pM0bqPTPNMr9ow6bQeubghy2+nYfklsx0MPkx7Oi6HlCLI7RwHYmg7WWfiJ4+/ P4bw== X-Gm-Message-State: AOAM533mgaZ9F4OWvNfYnn7ybwKx8qY3pJ/TDM2Ebz1laMchAg1pP3tB o4e0UcvF9tqZkrjncCOyj38tpw== X-Google-Smtp-Source: ABdhPJxiHd4wWA49qUn6yTSxex2CITvWAs8MaDikj6dKgx6kY3gZ6gIFiWxA3BuSpcV+jcVERuHs8w== X-Received: by 2002:a05:6638:25c4:b0:323:a5ba:e1a2 with SMTP id u4-20020a05663825c400b00323a5bae1a2mr324273jat.135.1648671697776; Wed, 30 Mar 2022 13:21:37 -0700 (PDT) Received: from [192.168.1.172] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id b12-20020a6be70c000000b00648f61d9652sm11510617ioh.52.2022.03.30.13.21.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 13:21:37 -0700 (PDT) Message-ID: Date: Wed, 30 Mar 2022 14:21:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [Drbd-dev] state of drbd in mainline Content-Language: en-US To: "Kiselev, Oleg" , Philipp Reisner Cc: "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Lars Ellenberg , Christoph Hellwig , "drbd-dev@lists.linbit.com" , "Herrenschmidt, Benjamin" , "Smith, Stewart" References: <20220329070618.GA20396@lst.de> <20220329073254.GA20691@lst.de> <3c42b1ed-7c03-64e6-409e-e92247288cac@kernel.dk> <7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com> From: Jens Axboe In-Reply-To: <7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/30/22 1:31 PM, Kiselev, Oleg wrote: > AWS RDS is a major user of drbd. We are probably responsible for the > substantial percentage of drbd users in the world. We are currently > on drbd-8.4. We will eventually migrate to drbd-9, but at our scale > this isn't going to happen very soon. > > The last time we needed to patch drbd was back in 2018. We've not > diagnosed any reportable issues with drbd-8.4 in the past ~4 years. > It's a stable, mature driver. We would prefer for drbd-8 to continue > being available in the upstream tree. We'd also welcome drbd-9 being > available in-tree as soon as possible: it will make life much easier > for other AWS teams that are currently working on DRBD deployment. Thanks for the info, that's useful and good to know. My objection was as much about ignoring patches that are sent for drbd, I don't recall seeing any replies to those kinds of emails in the last 3-4 years. Part of maintaining an in-tree driver is also dealing with those in a reasonable amount of time, and ensuring that they make it upstream. And the one bug fix that does look important was just sent upstream only because of this discussion, and that's been lingering for a year it seems. Roughly ordered by date: https://lore.kernel.org/all/20220327070918.8465-1-xiam0nd.tong@gmail.com/ https://lore.kernel.org/all/1648436049-4335-1-git-send-email-baihaowen@meizu.com/ https://lore.kernel.org/all/YbpERiPKO4ufe1hf@pc638.lan/ https://lore.kernel.org/all/20211213223331.135412-11-keescook@chromium.org/ [PATCH 0/2] drbd: Make use of PFN_UP helper macro (only on drbd list) https://lore.kernel.org/all/20210525065925.3978-1-lyl2019@mail.ustc.edu.cn/ https://lore.kernel.org/all/1619774456-116567-1-git-send-email-jiapeng.chong@linux.alibaba.com/ https://lore.kernel.org/all/20210426163032.3454129-1-christoph.boehmwalder@linbit.com/ (the referenced patch) https://lore.kernel.org/all/20210402070713.4069-1-lyl2019@mail.ustc.edu.cn/ (use after free, security issue?) https://lore.kernel.org/all/20201026215043.3893318-1-arnd@kernel.org/ This is just going back a bit, by no means an exhaustive list. Looking back to 2016-2017 and I see zero replies in emails like the above, not one. Everybody misses patches here and there, that's common. What isn't common is blatantly ignoring everything for, what, 5 years? I'm not here to babysit unmaintained drivers. linbit need to get their act together and maintain the driver, or it will get removed. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id C40B94202BA for ; Wed, 30 Mar 2022 22:21:38 +0200 (CEST) Received: by mail-io1-f44.google.com with SMTP id r2so26125483iod.9 for ; Wed, 30 Mar 2022 13:21:38 -0700 (PDT) Message-ID: Date: Wed, 30 Mar 2022 14:21:35 -0600 MIME-Version: 1.0 Content-Language: en-US To: "Kiselev, Oleg" , Philipp Reisner References: <20220329070618.GA20396@lst.de> <20220329073254.GA20691@lst.de> <3c42b1ed-7c03-64e6-409e-e92247288cac@kernel.dk> <7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com> From: Jens Axboe In-Reply-To: <7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Herrenschmidt, Benjamin" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , Lars Ellenberg , "Smith, Stewart" , Christoph Hellwig , "drbd-dev@lists.linbit.com" Subject: Re: [Drbd-dev] state of drbd in mainline List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 3/30/22 1:31 PM, Kiselev, Oleg wrote: > AWS RDS is a major user of drbd. We are probably responsible for the > substantial percentage of drbd users in the world. We are currently > on drbd-8.4. We will eventually migrate to drbd-9, but at our scale > this isn't going to happen very soon. > > The last time we needed to patch drbd was back in 2018. We've not > diagnosed any reportable issues with drbd-8.4 in the past ~4 years. > It's a stable, mature driver. We would prefer for drbd-8 to continue > being available in the upstream tree. We'd also welcome drbd-9 being > available in-tree as soon as possible: it will make life much easier > for other AWS teams that are currently working on DRBD deployment. Thanks for the info, that's useful and good to know. My objection was as much about ignoring patches that are sent for drbd, I don't recall seeing any replies to those kinds of emails in the last 3-4 years. Part of maintaining an in-tree driver is also dealing with those in a reasonable amount of time, and ensuring that they make it upstream. And the one bug fix that does look important was just sent upstream only because of this discussion, and that's been lingering for a year it seems. Roughly ordered by date: https://lore.kernel.org/all/20220327070918.8465-1-xiam0nd.tong@gmail.com/ https://lore.kernel.org/all/1648436049-4335-1-git-send-email-baihaowen@meizu.com/ https://lore.kernel.org/all/YbpERiPKO4ufe1hf@pc638.lan/ https://lore.kernel.org/all/20211213223331.135412-11-keescook@chromium.org/ [PATCH 0/2] drbd: Make use of PFN_UP helper macro (only on drbd list) https://lore.kernel.org/all/20210525065925.3978-1-lyl2019@mail.ustc.edu.cn/ https://lore.kernel.org/all/1619774456-116567-1-git-send-email-jiapeng.chong@linux.alibaba.com/ https://lore.kernel.org/all/20210426163032.3454129-1-christoph.boehmwalder@linbit.com/ (the referenced patch) https://lore.kernel.org/all/20210402070713.4069-1-lyl2019@mail.ustc.edu.cn/ (use after free, security issue?) https://lore.kernel.org/all/20201026215043.3893318-1-arnd@kernel.org/ This is just going back a bit, by no means an exhaustive list. Looking back to 2016-2017 and I see zero replies in emails like the above, not one. Everybody misses patches here and there, that's common. What isn't common is blatantly ignoring everything for, what, 5 years? I'm not here to babysit unmaintained drivers. linbit need to get their act together and maintain the driver, or it will get removed. -- Jens Axboe