From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elzK2-0001nv-GV for qemu-devel@nongnu.org; Wed, 14 Feb 2018 10:50:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elzK1-00052m-MT for qemu-devel@nongnu.org; Wed, 14 Feb 2018 10:50:14 -0500 References: <1518542328-25741-1-git-send-email-mihajlov@linux.vnet.ibm.com> <20180214115725.34ba0008.cohuck@redhat.com> From: Eric Blake Message-ID: Date: Wed, 14 Feb 2018 09:16:15 -0600 MIME-Version: 1.0 In-Reply-To: <20180214115725.34ba0008.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 0/3] add query-cpu-fast and related s390 changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Viktor Mihajlovski Cc: qemu-devel@nongnu.org, agraf@suse.de, ehabkost@redhat.com, armbru@redhat.com, david@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, pbonzini@redhat.com, rth@twiddle.net On 02/14/2018 04:57 AM, Cornelia Huck wrote: > On Tue, 13 Feb 2018 18:18:45 +0100 > Viktor Mihajlovski wrote: > >> Patch 1/3: >> Adds architecture specific data to the QMP CpuInfo type, exposing >> the existing s390 cpu-state in QMP. The cpu-state is a representation >> more adequate than the ambiguous 'halted' condition. >> >> Patch 2/3: >> Adds a new QMP function query-cpus-fast, which will only retrieve >> vCPU information that can be obtained without interrupting the >> vCPUs of a running VM. It introduces a new return type CpuInfoFast >> with the subset of fields meeting this condition. Specifically, the >> halted state is not part of CpuInfoFast. QMP clients like libvirt >> are encouraged to switch to the new API for vCPU information. >> >> Patch 3/3: >> Adds the s390-specific cpu state to CpuInfoFast, allowing management >> apps to find out whether a vCPU is in the stopped state. This extension >> leads to a partial duplication of field definitions from CpuInfo >> to CpuInfoFast. This should be tolerable if CpuInfo is deprecated and >> eventually removed. > > How shall we proceed with this series? Patch 3 depends upon patch 1, so > I think it makes sense to merge this in one go. > > I can give my R-b on patch 1 and Someone(tm) can merge this, or I can > take the whole series through the s390 tree (with some further > reviews/acks on patches 2/3). I'd still like to give a thorough QMP review; it's on my list to get to today. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org