All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: RE: [PATCH v2] drm/i915/hdcp: switch to drm_dp_dpcd_{read_byte,read_data,write_data}()
Date: Tue, 22 Sep 2026 16:43:02 +0300	[thread overview]
Message-ID: <a64d0bae43513a03528539bbf6cbcaa42c60acd5@intel.com> (raw)
In-Reply-To: <DS4PPFE901A304F108943697D7853999374E3832@DS4PPFE901A304F.namprd11.prod.outlook.com>

On Tue, 22 Sep 2026, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> Subject: [PATCH v2] drm/i915/hdcp: switch to
>> drm_dp_dpcd_{read_byte,read_data,write_data}()
>> 
>> Switch to the modern DPCD access functions that return negative error codes on
>> errors, -EIO for incomplete access, and 0 on success.
>> 
>> This simplifies error handling all over the place. Convert the error logging to use
>> %pe and ERR_PTR() while at it.
>> 
>> Add comments to the read/write places that depend on the functions that return
>> the number of bytes read/written for incomplete access.
>> 
>> v2: return length from get_receiver_id_list_rx_info() (Sashiko)
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

Thanks for the reviews, pushed the lot to drm-intel-next.

BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2026-09-22 13:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  8:29 [PATCH 00/11] drm/i915/display: switch to modern drm_dp_dpcd* accessors Jani Nikula
2026-09-16  8:29 ` [PATCH 01/11] drm/i915/lspcon: use u8 variable to hold 1-byte DPCD reads Jani Nikula
2026-09-16  9:14   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 02/11] drm/i915/lspcon: switch to drm_dp_dpcd_{read_byte, write_byte, write_data} Jani Nikula
2026-09-16  9:16   ` Kandpal, Suraj
2026-09-17 12:03     ` Jani Nikula
2026-09-18  3:02       ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 03/11] drm/i915/alpm: switch to drm_dp_dpcd_{read_byte, write_byte} Jani Nikula
2026-09-16  9:17   ` Kandpal, Suraj
2026-09-18  3:04     ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 04/11] drm/i915/ddi: switch to drm_dp_dpcd_write_byte() Jani Nikula
2026-09-18  3:05   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 05/11] drm/i915/lspcon: switch to drm_dp_dpcd_{read_byte, read_data, write_byte, write_data}() Jani Nikula
2026-09-18  3:08   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 06/11] drm/i915/dp: switch to drm_dp_dpcd_{read_byte, read_data, write_byte, write_data} Jani Nikula
2026-09-18  3:09   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 07/11] drm/i915/hdcp: switch to drm_dp_dpcd_{read_byte, read_data, write_data}() Jani Nikula
2026-09-16  8:35   ` sashiko-bot
2026-09-18  3:36     ` Kandpal, Suraj
2026-09-21  9:41   ` [PATCH v2] " Jani Nikula
2026-09-22 12:03     ` [PATCH v2] drm/i915/hdcp: switch to drm_dp_dpcd_{read_byte,read_data,write_data}() Kandpal, Suraj
2026-09-22 13:43       ` Jani Nikula [this message]
2026-09-16  8:29 ` [PATCH 08/11] drm/i915/dp: switch link training to drm_dp_dpcd_{read_byte, read_data, write_byte, write_data}() Jani Nikula
2026-09-18  3:38   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 09/11] drm/i915/dp-mst: switch to drm_dp_dpcd_read_byte() Jani Nikula
2026-09-16  9:29   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 10/11] drm/i915/dp-test: switch to drm_dp_dpcd_{read_byte, read_data, write_byte, write_data}() Jani Nikula
2026-09-18  3:38   ` Kandpal, Suraj
2026-09-16  8:29 ` [PATCH 11/11] drm/i915/psr: " Jani Nikula
2026-09-16  9:30   ` Kandpal, Suraj
2026-09-16  8:37 ` ✗ CI.checkpatch: warning for drm/i915/display: switch to modern drm_dp_dpcd* accessors Patchwork
2026-09-16  8:39 ` ✓ CI.KUnit: success " Patchwork
2026-09-16  9:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-16  9:44 ` ✓ i915.CI.BAT: " Patchwork
2026-09-16 10:51 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-16 14:26 ` ✓ i915.CI.Full: success " Patchwork
2026-09-21 11:12 ` ✗ CI.checkpatch: warning for drm/i915/display: switch to modern drm_dp_dpcd* accessors (rev2) Patchwork
2026-09-21 11:14 ` ✓ CI.KUnit: success " Patchwork
2026-09-21 12:45 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-21 13:10 ` ✓ i915.CI.BAT: success " Patchwork
2026-09-21 16:23 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-21 17:24 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a64d0bae43513a03528539bbf6cbcaa42c60acd5@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.