Re: [PATCH] libretech-cc: Populate SMBIOS information

[Neil Armstrong <neil.armstrong@linaro.org>]

Hi Tom,

On 20/11/2023 21:16, Tom Rini wrote:
> Enable CONFIG_SYSINFO_SMBIOS and populate the nodes so that Linux can
> eventually display this information
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Posting this as this was the easiest platform for me to test some SMBIOS
> related patches on and I needed to populate the nodes so I could check
> things in dmidecode once Linux was up.

Sorry to be late a the party, but can't this be dynamically found from DT's compatible & model ?
Since I'll probably need to add this to all boards, it seems like a duplicate of what's already in the DT.

> 
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: u-boot-amlogic@groups.io
> ---
>   .../meson-gxl-s905x-libretech-cc-u-boot.dtsi  | 23 +++++++++++++++++++
>   configs/libretech-cc_defconfig                |  2 ++
>   2 files changed, 25 insertions(+)
> 
> diff --git a/arch/arm/dts/meson-gxl-s905x-libretech-cc-u-boot.dtsi b/arch/arm/dts/meson-gxl-s905x-libretech-cc-u-boot.dtsi
> index 39270ea71c8b..e56cd67a9d91 100644
> --- a/arch/arm/dts/meson-gxl-s905x-libretech-cc-u-boot.dtsi
> +++ b/arch/arm/dts/meson-gxl-s905x-libretech-cc-u-boot.dtsi
> @@ -5,3 +5,26 @@
>    */
>   
>   #include "meson-gxl-u-boot.dtsi"
> +
> +/ {
> +	smbios {
> +		compatible = "u-boot,sysinfo-smbios";
> +
> +		smbios {
> +			system {
> +				manufacturer = "libre.computer";
> +				product = "Le Potato";

I'll use the real product identifier here instead: AML-S905X-CC

Here's the downstream vendor change:
https://github.com/libre-computer-project/libretech-u-boot/commit/cb68b838f1b80ad201ec02f04d2841ee535b9818

> +			};
> +
> +			baseboard {
> +				manufacturer = "libre.computer";
> +				product = "Le Potato";
> +			};
> +
> +			chassis {
> +				manufacturer = "libre.computer";
> +				product = "Le Potato";
> +			};
> +		};
> +	};
> +};
> diff --git a/configs/libretech-cc_defconfig b/configs/libretech-cc_defconfig
> index baa9b1b3dbc5..24a46f50d0d9 100644
> --- a/configs/libretech-cc_defconfig
> +++ b/configs/libretech-cc_defconfig
> @@ -55,6 +55,8 @@ CONFIG_DM_REGULATOR_FIXED=y
>   CONFIG_DEBUG_UART_ANNOUNCE=y
>   CONFIG_DEBUG_UART_SKIP_INIT=y
>   CONFIG_MESON_SERIAL=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
>   CONFIG_USB=y
>   CONFIG_DM_USB_GADGET=y
>   CONFIG_USB_XHCI_HCD=y

Thanks,
Neil