From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx76H-0005jy-6v for ath10k@lists.infradead.org; Tue, 04 Sep 2018 08:54:18 +0000 MIME-Version: 1.0 Date: Tue, 04 Sep 2018 14:24:06 +0530 From: Anilkumar Kolli Subject: Re: [PATCH 4/4] ath10k: add debugfs support to dump per sta tx stats In-Reply-To: <20180828133640.7D55E6044E@smtp.codeaurora.org> References: <1533561223-342-5-git-send-email-akolli@codeaurora.org> <20180828133640.7D55E6044E@smtp.codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 2018-08-28 19:06, Kalle Valo wrote: > Anilkumar Kolli wrote: > >> This patch adds 'tx_stats' in per station debugfs entry. >> >> Use this command to dump tx_stats: >> cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/ >> stations//tx_stats >> >> Signed-off-by: Anilkumar Kolli >> Signed-off-by: Kalle Valo > > kbuild bot found new warnings: > > drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function > 'ath10k_dbg_sta_dump_tx_stats': >>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:714:1: warning: the >>> frame size of 1088 bytes is larger than 1024 bytes >>> [-Wframe-larger-than=] > } > ^ > > drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function > 'ath10k_sta_add_debugfs': >>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:737:41: error: 'struct >>> ath10k' has no member named 'debug' > if (ath10k_peer_stats_enabled(ar) && > ar->debug.enable_extd_tx_stats) > ^~ Please drop this patch series, I sent V2 addressing these issues. Thanks Anil. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:42760 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbeIDNSQ (ORCPT ); Tue, 4 Sep 2018 09:18:16 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Tue, 04 Sep 2018 14:24:06 +0530 From: Anilkumar Kolli To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 4/4] ath10k: add debugfs support to dump per sta tx stats In-Reply-To: <20180828133640.7D55E6044E@smtp.codeaurora.org> References: <1533561223-342-5-git-send-email-akolli@codeaurora.org> <20180828133640.7D55E6044E@smtp.codeaurora.org> Message-ID: (sfid-20180904_105409_601422_313338A0) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-08-28 19:06, Kalle Valo wrote: > Anilkumar Kolli wrote: > >> This patch adds 'tx_stats' in per station debugfs entry. >> >> Use this command to dump tx_stats: >> cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/ >> stations//tx_stats >> >> Signed-off-by: Anilkumar Kolli >> Signed-off-by: Kalle Valo > > kbuild bot found new warnings: > > drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function > 'ath10k_dbg_sta_dump_tx_stats': >>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:714:1: warning: the >>> frame size of 1088 bytes is larger than 1024 bytes >>> [-Wframe-larger-than=] > } > ^ > > drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function > 'ath10k_sta_add_debugfs': >>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:737:41: error: 'struct >>> ath10k' has no member named 'debug' > if (ath10k_peer_stats_enabled(ar) && > ar->debug.enable_extd_tx_stats) > ^~ Please drop this patch series, I sent V2 addressing these issues. Thanks Anil.