All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: "Orzel, Michal" <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4 1/4] xen/arm: vcpu_vgic_free() updates
Date: Tue, 30 Dec 2025 16:52:42 +0100	[thread overview]
Message-ID: <a691f12f-e453-4286-a0ff-d6db8f582874@gmail.com> (raw)
In-Reply-To: <4c09cc87-307e-440d-9a1d-7ef2313ae466@amd.com>


On 12/29/25 11:50 AM, Orzel, Michal wrote:
>
> On 23/12/2025 18:01, Oleksii Kurochko wrote:
>> Use XFREE() instead of xfree() so that vcpu_vgic_free() can be idempotent.
>> With XFREE(), vgic_vcpu->private_irqs is set to NULL, so calling
>> vcpu_vgic_free() a second time is not an issue.
> Usually it would be beneficial to back such statement with an example of a
> situation where this is or will be the issue.

I think there is not a case now in current code base, but just common practice
to have such type of functions to be idempotent.

>
>> Update the prototype of vcpu_vgic_free() to return void to satisfy MISRA
>> Rule 17.7, since the return value of vcpu_vgic_free() is not used by any
>> callers.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Michal Orzel <michal.orzel@amd.com>

Thanks.

~ Oleksii



  reply	other threads:[~2025-12-30 15:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 17:01 [PATCH v4 0/4] Move alloc/free_vcpu_struct() to common code Oleksii Kurochko
2025-12-23 17:01 ` [PATCH v4 1/4] xen/arm: vcpu_vgic_free() updates Oleksii Kurochko
2025-12-29 10:50   ` Orzel, Michal
2025-12-30 15:52     ` Oleksii Kurochko [this message]
2025-12-23 17:01 ` [PATCH v4 2/4] xen/arm: optimize the size of struct vcpu Oleksii Kurochko
2025-12-29 11:08   ` Orzel, Michal
2025-12-29 11:10     ` Orzel, Michal
2025-12-29 11:27       ` Andrew Cooper
2025-12-31  8:27       ` Oleksii Kurochko
2026-01-05 14:44         ` Jan Beulich
2025-12-30 16:04     ` Oleksii Kurochko
2025-12-23 17:01 ` [PATCH v4 3/4] xen: move alloc/free_vcpu_struct() to common code Oleksii Kurochko
2025-12-23 17:01 ` [PATCH v4 4/4] xen/common: make {alloc,free}_domain_struct() static Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a691f12f-e453-4286-a0ff-d6db8f582874@gmail.com \
    --to=oleksii.kurochko@gmail.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.