From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] io_uring: signedness bug in io_async_cancel()
Date: Thu, 31 Oct 2019 12:57:06 +0000 [thread overview]
Message-ID: <a697c16b-92bb-52a3-e2e8-5f24d75f580d@kernel.dk> (raw)
In-Reply-To: <20191031105547.GC26612@mwanda>
On 10/31/19 4:55 AM, Dan Carpenter wrote:
> The problem is that this enum is unsigned, and we do use "ret" for the
> enum values, but we also use it for negative error codes. If it's not
> signed then it causes a problem in the error handling.
I noticed this one the other day, merged in a fix for it then. Not
an issue in the current tree, though linux-next may still have the
older one.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] io_uring: signedness bug in io_async_cancel()
Date: Thu, 31 Oct 2019 06:57:06 -0600 [thread overview]
Message-ID: <a697c16b-92bb-52a3-e2e8-5f24d75f580d@kernel.dk> (raw)
In-Reply-To: <20191031105547.GC26612@mwanda>
On 10/31/19 4:55 AM, Dan Carpenter wrote:
> The problem is that this enum is unsigned, and we do use "ret" for the
> enum values, but we also use it for negative error codes. If it's not
> signed then it causes a problem in the error handling.
I noticed this one the other day, merged in a fix for it then. Not
an issue in the current tree, though linux-next may still have the
older one.
--
Jens Axboe
next prev parent reply other threads:[~2019-10-31 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 10:55 [PATCH] io_uring: signedness bug in io_async_cancel() Dan Carpenter
2019-10-31 10:55 ` Dan Carpenter
2019-10-31 12:57 ` Jens Axboe [this message]
2019-10-31 12:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a697c16b-92bb-52a3-e2e8-5f24d75f580d@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.