From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A51C433EF for ; Wed, 15 Sep 2021 12:18:48 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64AA36135A for ; Wed, 15 Sep 2021 12:18:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64AA36135A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 250EA40190; Wed, 15 Sep 2021 12:18:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xTnf0JHftayD; Wed, 15 Sep 2021 12:18:47 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1098140278; Wed, 15 Sep 2021 12:18:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C1A72C0011; Wed, 15 Sep 2021 12:18:46 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8BDE4C000D for ; Wed, 15 Sep 2021 12:18:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7B36340190 for ; Wed, 15 Sep 2021 12:18:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QrLvaUMIPL7X for ; Wed, 15 Sep 2021 12:18:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by smtp4.osuosl.org (Postfix) with ESMTPS id A1FAE40131 for ; Wed, 15 Sep 2021 12:18:44 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id y6so759397lje.2 for ; Wed, 15 Sep 2021 05:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1i3GCJ4doVicCCYOf0G/3mlg9/kUYxhDqZIWzyEw4ms=; b=Vhmi2Bm0ZkGI+gvjFqbIHxkyKObUNpOs1XqI03pHL6WYn+gn0EqHawQDT57tzPcQGV N9WmG3L8dWRobG9f7UNBVvlFyLCY16V0aCYvYtftpmtm48EeQmoCmeBkVD8Zqh4F1PMX cPwv57TqUCLBf4CBzSCPZ2ard2faHu5eGQ4c9vODf9wuuCXq3gCGAMnkQ4ihcOITa8jb WLDVFIv1J1O0EWpmLZS1GbCyr32rcdx/ZUqa6o64I8Tm9ccvIBXJWB2vbZ62D8TVXWty 4Pj9MlAwvzBz2ndMTzj0lG5qmP5jJaqNmg2AaggznOruRtIn0QH9T8YKrbnFMO//bXEq cU3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1i3GCJ4doVicCCYOf0G/3mlg9/kUYxhDqZIWzyEw4ms=; b=TkZ3Qlf3Zmh5j77t6UioReNnG37ume88GQP4wu1jaueyXGxgFihi6qFfaFDAdGZrtJ 8rr8MVvF4M/+0FOeyxeY3cTuxLSACBieljlXg8Jab/ziEI4xprN2GtC0XqOPkuhDrIEn adeuyxYCtNeMlmr2fjlkdN3eT+juHRiQLzwe+RM7xJJ4QmydNrqhJhUqSjkTVZ5bMXUv lQSUo+RTXBrAmWsf6YabggXryrE01L6g0ffBqChaSahJWiTTmIzbipHK2LtsJJswMyZn oaaF01xD7IGtdMM6LgTHgpeyJSVsSiZP1J61hrNVW2UYp1IxrJPxSKkC5lw/paR+BAif oWmg== X-Gm-Message-State: AOAM531Lj+pUMh69PIh38RVftq9Jb7giiUoOsogyw8YD46weCs4kPCGN Fa9lFEIiTXVgdaHXYxrOsJg= X-Google-Smtp-Source: ABdhPJwsgEhnVvxdvq4n/fOx+m8wCX/L09qukP2GXddLOIUV6O6QmvJMB4oXxVe/pYD2+56dqwihwQ== X-Received: by 2002:a2e:9b14:: with SMTP id u20mr20545302lji.21.1631708322472; Wed, 15 Sep 2021 05:18:42 -0700 (PDT) Received: from [192.168.2.145] (94-29-62-67.dynamic.spd-mgts.ru. [94.29.62.67]) by smtp.googlemail.com with ESMTPSA id r13sm1624028ljh.61.2021.09.15.05.18.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 05:18:42 -0700 (PDT) Subject: Re: [PATCH v6 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs From: Dmitry Osipenko To: Nicolin Chen References: <20210914013858.31192-1-nicoleotsuka@gmail.com> <20210914013858.31192-7-nicoleotsuka@gmail.com> <31501a62-3312-9f04-3bb8-790d0481746c@gmail.com> <20210914184933.GA32705@Asurada-Nvidia> <25d68aff-323a-df54-45f9-55b22f3089e0@gmail.com> <20210915043806.GA19185@Asurada-Nvidia> Message-ID: Date: Wed, 15 Sep 2021 15:18:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, will@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" MTUuMDkuMjAyMSAxNTowOSwgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4gMTUuMDkuMjAy MSAwNzozOCwgTmljb2xpbiBDaGVuINC/0LjRiNC10YI6Cj4+IE9uIFR1ZSwgU2VwIDE0LCAyMDIx IGF0IDEwOjIwOjMwUE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4+IDE0LjA5LjIw MjEgMjE6NDksIE5pY29saW4gQ2hlbiDQv9C40YjQtdGCOgo+Pj4+IE9uIFR1ZSwgU2VwIDE0LCAy MDIxIGF0IDA0OjI5OjE1UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4+Pj4gMTQu MDkuMjAyMSAwNDozOCwgTmljb2xpbiBDaGVuINC/0LjRiNC10YI6Cj4+Pj4+PiArc3RhdGljIHVu c2lnbmVkIGxvbmcgcGRfcHRfaW5kZXhfaW92YSh1bnNpZ25lZCBpbnQgcGRfaW5kZXgsIHVuc2ln bmVkIGludCBwdF9pbmRleCkKPj4+Pj4+ICt7Cj4+Pj4+PiArCXJldHVybiAoKGRtYV9hZGRyX3Qp cGRfaW5kZXggJiAoU01NVV9OVU1fUERFIC0gMSkpIDw8IFNNTVVfUERFX1NISUZUIHwKPj4+Pj4+ ICsJICAgICAgICgoZG1hX2FkZHJfdClwdF9pbmRleCAmIChTTU1VX05VTV9QVEUgLSAxKSkgPDwg U01NVV9QVEVfU0hJRlQ7Cj4+Pj4+PiArfQo+Pj4+Pgo+Pj4+PiBXZSBrbm93IHRoYXQgSU9WQSBp cyBmaXhlZCB0byB1MzIgZm9yIHRoaXMgY29udHJvbGxlci4gQ2FuIHdlIGF2b2lkIGFsbAo+Pj4+ PiB0aGVzZSBkbWFfYWRkcl90IGNhc3RpbmdzPyBJdCBzaG91bGQgbWFrZSBjb2RlIGNsZWFuZXIg YSB0YWQsIElNTy4KPj4+Pgo+Pj4+IFRlZ3JhMjEwIGFjdHVhbGx5IHN1cHBvcnRzIDM0LWJpdCBJ T1ZBLi4uCj4+Pj4KPj4+Cj4+PiBJdCBkb2Vzbid0LiAzNC1iaXQgaXMgUEEsIDMyLWJpdCBpcyBW QS4KPj4+Cj4+PiBRdW90ZSBmcm9tIFQyMTAgVFJNOgo+Pj4KPj4+ICJUaGUgU01NVSBpcyBhIGNl bnRyYWxpemVkIHZpcnR1YWwtdG8tcGh5c2ljYWwgdHJhbnNsYXRpb24gZm9yIE1TUy4gSXQKPj4+ IG1hcHMgYSAzMi1iaXQgdmlydHVhbCBhZGRyZXNzIHRvIGEgMzQtYml0IHBoeXNpY2FsIGFkZHJl c3MuIElmIHRoZQo+Pj4gY2xpZW50IGFkZHJlc3MgaXMgNDAgYml0cyB0aGVuIGJpdHMgMzk6MzIg YXJlIGlnbm9yZWQuIgo+Pgo+PiBJZiB5b3Ugc2Nyb2xsIGRvd24gYnkgYSBjb3VwbGUgb2Ygc2Vj dGlvbnMsIHlvdSBjYW4gc2VlIDM0LWJpdAo+PiB2aXJ0dWFsIGFkZHJlc3NlcyBpbiBzZWN0aW9u IDE4LjYuMS4yOyBhbmQgaWYgY2hlY2tpbmcgb25lIEFTSUQKPj4gcmVnaXN0ZXIsIHlvdSBjYW4g c2VlIGl0IG1lbnRpb24gdGhlIGV4dHJhIHR3byBiaXRzIHZhWzMzOjMyXS4KPiAKPiBUaGFua3Mg Zm9yIHRoZSBwb2ludGVyLiBJdCBzYXlzIHRoYXQgb25seSBjZXJ0YWluIG1lbW9yeSBjbGllbnRz IGFsbG93Cj4gdG8gY29tYmluZSA0IEFTSURzIHRvIGZvcm0gMzRiaXQgVkEgc3BhY2UuIEluIHRo aXMgY2FzZSB0aGUgUEEgc3BhY2UgaXMKPiBzcGxpdCBpbnRvIDRHQiBhcmVhcyBhbmQgdGhlcmUg YXJlIGFkZGl0aW9uYWwgYml0ZmllbGRzIHdoaWNoIGNvbmZpZ3VyZQo+IHRoZSBBU0lEIG1hcHBp bmcgb2YgZWFjaCA0R0IgYXJlYS4gU3RpbGwgZWFjaCBBU0lEIGlzIDMyYml0Lgo+IAo+IFRoaXMg aXMgd2hhdCBUUk0gc2F5czoKPiAKPiAiRm9yIHRoZSBHUFUgYW5kIG90aGVyIGNsaWVudHMgd2l0 aCAzNC1iaXQgYWRkcmVzcyBpbnRlcmZhY2VzLCB0aGUgQVNJRAo+IHJlZ2lzdGVycyBhcmUgZXh0 ZW5kZWQgdG8gcG9pbnQgdG8gZm91ciBBU0lEcy4gVGhlIFNNTVUgc3VwcG9ydHMgNEdCIG9mCj4g dmlydHVhbCBhZGRyZXNzIHNwYWNlIHBlciBBU0lELCBzbyBtYXBwaW5nIGFkZHJbMzM6MzJdIGlu dG8gQVNJRFsxOjBdCj4gZXh0ZW5kcyB0aGUgdmlydHVhbCBhZGRyZXNzIHNwYWNlIG9mIGEgY2xp ZW50IHRvIDE2R0IuIgo+IAo+PiBIb3dldmVyLCB0aGUgZHJpdmVyIGN1cnJlbnRseSBzZXRzIGl0 cyBnZW9tZXRyeS5hcGVydHVyZV9lbmQgdG8KPj4gMzItYml0LCBhbmQgd2UgY2FuIG9ubHkgZ2V0 IDMyLWJpdCBJT1ZBcyB1c2luZyBQREUgYW5kIFBURSBvbmx5LAo+PiBzbyBJIHRoaW5rIGl0IHNo b3VsZCBiZSBzYWZlIHRvIHJlbW92ZSB0aGUgY2FzdGluZ3MgaGVyZS4gSSdsbAo+PiB3YWl0IGZv ciBhIGNvdXBsZSBvZiBkYXlzIGFuZCBzZWUgaWYgdGhlcmUnZCBiZSBvdGhlciBjb21tZW50cwo+ PiBmb3IgbWUgdG8gYWRkcmVzcyBpbiBuZXh0IHZlcnNpb24uCj4gCj4gWW91IHdpbGwgbmVlZCB0 byByZWFkIHRoZSBzcGVjaWFsICJBU0lEIEFzc2lnbm1lbnQgUmVnaXN0ZXIiIHdoaWNoCj4gc3Vw cG9ydHMgNCBzdWItQVNJRHMgdG8gdHJhbnNsYXRlIHRoZSBQQSBhZGRyZXNzIGludG8gdGhlIGFj dHVhbCBWQS4gQnkKCiogVkEgdG8gUEEKCj4gZGVmYXVsdCBhbGwgY2xpZW50cyBhcmUgbGltaXRl ZCB0byBhIHNpbmdsZSBBU0lEIGFuZCB1cHN0cmVhbSBrZXJuZWwKPiBkb2Vzbid0IHN1cHBvcnQg cHJvZ3JhbW1pbmcgb2YgMzRiaXQgVkFzLiBTbyBkb2Vzbid0IHdvcnRoIHRoZSBlZmZvcnQgdG8K PiBmdWxseSB0cmFuc2xhdGUgdGhlIFZBLCBJTU8uCj4gCj4+PiBFdmVuIGlmIGl0IHN1cHBvcnRl ZCBtb3JlIHRoYW4gMzJiaXQsIHRoZW4gdGhlIHJldHVybmVkIHVsb25nIGlzIDMyYml0LAo+Pj4g d2hpY2ggZG9lc24ndCBtYWtlIHNlbnNlLgo+Pgo+PiBPbiBBUk02NCAoVGVncmEyMTApLCBpc24n dCB1bG9uZyA2NC1iaXQ/Cj4gCj4gWWVzLCBpbmRlZWQuCj4gCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52228C433EF for ; Wed, 15 Sep 2021 12:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 302B16135A for ; Wed, 15 Sep 2021 12:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236558AbhIOMUG (ORCPT ); Wed, 15 Sep 2021 08:20:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbhIOMUD (ORCPT ); Wed, 15 Sep 2021 08:20:03 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65902C061574; Wed, 15 Sep 2021 05:18:44 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id s3so687546ljp.11; Wed, 15 Sep 2021 05:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1i3GCJ4doVicCCYOf0G/3mlg9/kUYxhDqZIWzyEw4ms=; b=Vhmi2Bm0ZkGI+gvjFqbIHxkyKObUNpOs1XqI03pHL6WYn+gn0EqHawQDT57tzPcQGV N9WmG3L8dWRobG9f7UNBVvlFyLCY16V0aCYvYtftpmtm48EeQmoCmeBkVD8Zqh4F1PMX cPwv57TqUCLBf4CBzSCPZ2ard2faHu5eGQ4c9vODf9wuuCXq3gCGAMnkQ4ihcOITa8jb WLDVFIv1J1O0EWpmLZS1GbCyr32rcdx/ZUqa6o64I8Tm9ccvIBXJWB2vbZ62D8TVXWty 4Pj9MlAwvzBz2ndMTzj0lG5qmP5jJaqNmg2AaggznOruRtIn0QH9T8YKrbnFMO//bXEq cU3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1i3GCJ4doVicCCYOf0G/3mlg9/kUYxhDqZIWzyEw4ms=; b=k69YjzUZgw7KCfFRvMwJtErhrC2pf4QrD8ScRpaah8W+634h1fWbI7t7UvK0NbW3b7 JtZGeuOaBP0LiqPsVEBp4KwBXCtRiNgGPO7gTkfx3fMpPXYBIYqK8xoud+YgcHqLof0T MW0BgJmMqmvrs40DVO19Cgxmu9rkhXnDNldUmrUytId+VMetRFo9KL0F+iccdIk/D/OT ljnjiaGNUzB7obLtCsiBPTQN4xFoyU2mC/Q1nEMa04PYpq4svrx/7lu2FkXEmJjBlxr0 CzFi3p3ppOIejN0iNC0Uwb4ix8V8cP2LWhAgTBIhvEh5ca3zuMkcUao3VbMYGpziwUja NoHA== X-Gm-Message-State: AOAM531WEcgX0mN8558uPHLG9r9pS5NebbkrVpPh5qbMZa1BDJaFikxY t2yduQu5CAV4+b2yy4exz69d6swOXW8= X-Google-Smtp-Source: ABdhPJwsgEhnVvxdvq4n/fOx+m8wCX/L09qukP2GXddLOIUV6O6QmvJMB4oXxVe/pYD2+56dqwihwQ== X-Received: by 2002:a2e:9b14:: with SMTP id u20mr20545302lji.21.1631708322472; Wed, 15 Sep 2021 05:18:42 -0700 (PDT) Received: from [192.168.2.145] (94-29-62-67.dynamic.spd-mgts.ru. [94.29.62.67]) by smtp.googlemail.com with ESMTPSA id r13sm1624028ljh.61.2021.09.15.05.18.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 05:18:42 -0700 (PDT) Subject: Re: [PATCH v6 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs From: Dmitry Osipenko To: Nicolin Chen Cc: thierry.reding@gmail.com, joro@8bytes.org, will@kernel.org, vdumpa@nvidia.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20210914013858.31192-1-nicoleotsuka@gmail.com> <20210914013858.31192-7-nicoleotsuka@gmail.com> <31501a62-3312-9f04-3bb8-790d0481746c@gmail.com> <20210914184933.GA32705@Asurada-Nvidia> <25d68aff-323a-df54-45f9-55b22f3089e0@gmail.com> <20210915043806.GA19185@Asurada-Nvidia> Message-ID: Date: Wed, 15 Sep 2021 15:18:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 15.09.2021 15:09, Dmitry Osipenko пишет: > 15.09.2021 07:38, Nicolin Chen пишет: >> On Tue, Sep 14, 2021 at 10:20:30PM +0300, Dmitry Osipenko wrote: >>> 14.09.2021 21:49, Nicolin Chen пишет: >>>> On Tue, Sep 14, 2021 at 04:29:15PM +0300, Dmitry Osipenko wrote: >>>>> 14.09.2021 04:38, Nicolin Chen пишет: >>>>>> +static unsigned long pd_pt_index_iova(unsigned int pd_index, unsigned int pt_index) >>>>>> +{ >>>>>> + return ((dma_addr_t)pd_index & (SMMU_NUM_PDE - 1)) << SMMU_PDE_SHIFT | >>>>>> + ((dma_addr_t)pt_index & (SMMU_NUM_PTE - 1)) << SMMU_PTE_SHIFT; >>>>>> +} >>>>> >>>>> We know that IOVA is fixed to u32 for this controller. Can we avoid all >>>>> these dma_addr_t castings? It should make code cleaner a tad, IMO. >>>> >>>> Tegra210 actually supports 34-bit IOVA... >>>> >>> >>> It doesn't. 34-bit is PA, 32-bit is VA. >>> >>> Quote from T210 TRM: >>> >>> "The SMMU is a centralized virtual-to-physical translation for MSS. It >>> maps a 32-bit virtual address to a 34-bit physical address. If the >>> client address is 40 bits then bits 39:32 are ignored." >> >> If you scroll down by a couple of sections, you can see 34-bit >> virtual addresses in section 18.6.1.2; and if checking one ASID >> register, you can see it mention the extra two bits va[33:32]. > > Thanks for the pointer. It says that only certain memory clients allow > to combine 4 ASIDs to form 34bit VA space. In this case the PA space is > split into 4GB areas and there are additional bitfields which configure > the ASID mapping of each 4GB area. Still each ASID is 32bit. > > This is what TRM says: > > "For the GPU and other clients with 34-bit address interfaces, the ASID > registers are extended to point to four ASIDs. The SMMU supports 4GB of > virtual address space per ASID, so mapping addr[33:32] into ASID[1:0] > extends the virtual address space of a client to 16GB." > >> However, the driver currently sets its geometry.aperture_end to >> 32-bit, and we can only get 32-bit IOVAs using PDE and PTE only, >> so I think it should be safe to remove the castings here. I'll >> wait for a couple of days and see if there'd be other comments >> for me to address in next version. > > You will need to read the special "ASID Assignment Register" which > supports 4 sub-ASIDs to translate the PA address into the actual VA. By * VA to PA > default all clients are limited to a single ASID and upstream kernel > doesn't support programming of 34bit VAs. So doesn't worth the effort to > fully translate the VA, IMO. > >>> Even if it supported more than 32bit, then the returned ulong is 32bit, >>> which doesn't make sense. >> >> On ARM64 (Tegra210), isn't ulong 64-bit? > > Yes, indeed. >