All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: Use of "?" for help has been deprecated for 8 years, can we drop it?
Date: Thu, 1 Oct 2020 17:04:49 +0200	[thread overview]
Message-ID: <a6c8482f-df8b-cb86-5aee-2601acdb875f@redhat.com> (raw)
In-Reply-To: <20201001131714.GC6673@linux.fritz.box>

On 01/10/2020 15.17, Kevin Wolf wrote:
> Am 01.10.2020 um 15:06 hat Eric Blake geschrieben:
>> On 10/1/20 5:35 AM, Markus Armbruster wrote:
>>> We deprecated "?" more than eight years ago.  We didn't have a
>>> deprecation process back then, but we did purge "?" from the
>>> documentation and from help texts.  Can we finally drop it?
>>>
>>> I'm asking because there is a patch on the list that bypasses
>>> is_help_option() to not add deprecated "?" to a new place: "[PATCH v2
>>> 1/4] keyval: Parse help options".
>>>
>>
>> Did we ever issue a warning when it was used?  It's easier to argue that
>> it can be dropped if users had notice of some form or another.  That
>> said, I'm not heartbroken if we yank it immediately instead of letting
>> it live for 2 more releases.
> 
> A deprecation warning for a help option would somehow feel strange.
> 
> I would consider this a human-only interface that can be changed at
> will, like HMP syntax.

I'm not so sure ... for example we use "-device help" in the qemu-iotest
scripts, so other people out there might use "-device ?" in their
scripts, too, to check for the availability of devices... so IMHO we
should follow the deprecation process properly here.

 Thomas



  reply	other threads:[~2020-10-01 15:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 10:35 Use of "?" for help has been deprecated for 8 years, can we drop it? Markus Armbruster
2020-10-01 10:46 ` Thomas Huth
2020-10-01 11:20 ` Peter Maydell
2020-10-01 15:23   ` Christian Borntraeger
2020-10-01 15:45     ` Kevin Wolf
2020-10-01 13:06 ` Eric Blake
2020-10-01 13:17   ` Kevin Wolf
2020-10-01 15:04     ` Thomas Huth [this message]
2020-10-01 14:02   ` BALATON Zoltan via
2020-10-02 10:50     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6c8482f-df8b-cb86-5aee-2601acdb875f@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.