From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Sohil Mehta <sohil.mehta@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Yuntao Wang <yuntao.wang@linux.dev>,
Zhang Rui <rui.zhang@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: x86/apic: Drop useless CXL/CPX row from the TSC deadline errata table
Date: Fri, 18 Jul 2025 11:43:47 +0100 [thread overview]
Message-ID: <a6d7becc-9971-4e35-982a-3e35af4c4666@citrix.com> (raw)
In-Reply-To: <7fcede81-902c-4eaf-82be-cfaf3154bce9@intel.com>
On 17/07/2025 9:25 pm, Sohil Mehta wrote:
> On 7/16/2025 9:08 AM, Andrew Cooper wrote:
>> A microcode revision of 0 is guaranteed to exit apic_validate_deadline_timer()
>> early, but a better way is with no row at all.
>>
> Yeah, not having an entry is much better. "exit" can be a bit ambiguous.
> Should we be slightly more precise?
It's "exit $foo early", although this is slightly hidden by the linebreak.
Alternatively, it could be phrased as "exit early from $foo" if you
think that's clearer?
>
> A microcode revision of 0 is guaranteed to return true for
> apic_validate_deadline_timer(), but a better way is with no row at all.
>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
Thanks.
~Andrew
next prev parent reply other threads:[~2025-07-18 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 16:08 x86/apic: Drop useless CXL/CPX row from the TSC deadline errata table Andrew Cooper
2025-07-17 20:25 ` Sohil Mehta
2025-07-18 10:43 ` Andrew Cooper [this message]
2025-07-18 19:25 ` Sohil Mehta
2026-01-06 15:16 ` x86/apic: Drop useless " Dave Hansen
2026-01-06 18:14 ` [PATCH v2] x86/apic: Drop useless CXL/CPX " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d7becc-9971-4e35-982a-3e35af4c4666@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rui.zhang@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yuntao.wang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.