From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Christian Marangi" <ansuelsmth@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Daniel González Cabanelas" <dgcbueu@gmail.com>
Subject: Re: [PATCH v2 1/5] mips: bmips: BCM6358: make sure CBR is correctly set
Date: Fri, 3 May 2024 14:23:20 -0700 [thread overview]
Message-ID: <a6e178d1-da53-4e03-b1bb-c8343fdcfb59@broadcom.com> (raw)
In-Reply-To: <20240503212139.5811-2-ansuelsmth@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On 5/3/24 14:20, Christian Marangi wrote:
> It was discovered that some device have CBR address set to 0 causing
> kernel panic when arch_sync_dma_for_cpu_all is called.
>
> This was notice in situation where the system is booted from TP1 and
> BMIPS_GET_CBR() returns 0 instead of a valid address and
> !!(read_c0_brcm_cmt_local() & (1 << 31)); not failing.
>
> The current check whether RAC flush should be disabled or not are not
> enough hence lets check if CBR is a valid address or not.
>
> Fixes: ab327f8acdf8 ("mips: bmips: BCM6358: disable RAC flush for TP1")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2024-05-03 21:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 21:20 [PATCH v2 0/5] mips: bmips: improve handling of RAC and CBR addr Christian Marangi
2024-05-03 21:20 ` [PATCH v2 1/5] mips: bmips: BCM6358: make sure CBR is correctly set Christian Marangi
2024-05-03 21:23 ` Florian Fainelli [this message]
2024-05-03 21:20 ` [PATCH v2 2/5] mips: bmips: rework and cache CBR addr handling Christian Marangi
2024-05-03 21:23 ` Florian Fainelli
2024-05-08 23:13 ` kernel test robot
2024-05-09 11:15 ` Christian Marangi
2024-05-03 21:20 ` [PATCH v2 3/5] dt-bindings: mips: brcm: Document brcm,bmips-cbr-reg property Christian Marangi
2024-05-03 22:16 ` Rob Herring (Arm)
2024-05-07 13:07 ` Rob Herring
2024-05-08 16:44 ` Florian Fainelli
2024-05-03 21:21 ` [PATCH v2 4/5] mips: bmips: setup: make CBR address configurable Christian Marangi
2024-05-03 21:21 ` [PATCH v2 5/5] mips: bmips: enable RAC on BMIPS4350 Christian Marangi
2024-05-03 21:33 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6e178d1-da53-4e03-b1bb-c8343fdcfb59@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dgcbueu@gmail.com \
--cc=hauke@hauke-m.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.