From: Stephen Boyd <sboyd@kernel.org>
To: Rayyan Ansari <rayyan@ansari.sh>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
devicetree@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 1/3] clk: qcom: smd: Add XO RPM clocks for MSM8226/MSM8974
Date: Wed, 25 Jan 2023 15:00:19 -0800 [thread overview]
Message-ID: <a7058fb92642a1661995d7d3ca6411bd.sboyd@kernel.org> (raw)
In-Reply-To: <4c531c68-b74f-2f90-e8f6-98a4b0316cd4@ansari.sh>
Quoting Rayyan Ansari (2023-01-25 14:25:08)
> On 25/01/2023 20:58, Stephen Boyd wrote:
> > Quoting Rayyan Ansari (2023-01-21 11:25:38)
> >> Add the XO and XO_A clocks to the MSM8974 clock list, which is also
> >> used on MSM8226.
> >
> > Why was this missing for so long? Does this break suspend? Why are you
> > adding it now?
>
> I am adding it because of a recommendation from a maintainer on an older
> patch version.
> See
> https://lore.kernel.org/linux-arm-msm/20230119023337.h6a7f56lizhv4tcy@builder.lan/#t
So nobody has tested this on msm8974? Can you add this information to
the commit text? And can it be tested on msm8974?
next prev parent reply other threads:[~2023-01-25 23:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 19:25 [PATCH v4 0/3] Add XO clocks for MSM8226/MSM8974 Rayyan Ansari
2023-01-21 19:25 ` [PATCH v4 1/3] clk: qcom: smd: Add XO RPM " Rayyan Ansari
2023-01-23 16:50 ` Konrad Dybcio
2023-01-25 20:58 ` Stephen Boyd
2023-01-25 22:25 ` Rayyan Ansari
2023-01-25 23:00 ` Stephen Boyd [this message]
2023-01-25 23:33 ` Konrad Dybcio
2023-01-27 8:18 ` Luca Weiss
2023-01-21 19:25 ` [PATCH v4 2/3] ARM: dts: qcom: msm8226: add clocks and clock-names to GCC node Rayyan Ansari
2023-01-23 16:54 ` Konrad Dybcio
2023-01-21 19:25 ` [PATCH v4 3/3] ARM: dts: qcom: msm8974: add correct XO clock source " Rayyan Ansari
2023-03-16 3:21 ` (subset) [PATCH v4 0/3] Add XO clocks for MSM8226/MSM8974 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7058fb92642a1661995d7d3ca6411bd.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rayyan@ansari.sh \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.