From: Alexander H Duyck <alexander.duyck@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next resubmit v2] r8169: disable ASPM in case of tx timeout
Date: Wed, 11 Jan 2023 08:16:43 -0800 [thread overview]
Message-ID: <a709b727f117fbcad7bdd5abccfaa891775dbc65.camel@gmail.com> (raw)
In-Reply-To: <92369a92-dc32-4529-0509-11459ba0e391@gmail.com>
On Tue, 2023-01-10 at 23:03 +0100, Heiner Kallweit wrote:
> There are still single reports of systems where ASPM incompatibilities
> cause tx timeouts. It's not clear whom to blame, so let's disable
> ASPM in case of a tx timeout.
>
> v2:
> - add one-time warning for informing the user
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
From past experience I have seen ASPM issues cause the device to
disappear from the bus after failing to come out of L1. If that occurs
this won't be able to recover after the timeout without resetting the
bus itself. As such it may be necessary to disable the link states
prior to using the device rather than waiting until after the error.
That can be addressed in a follow-on patch if this doesn't resolve the
issue.
As for the code it looks fine to me.
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
next prev parent reply other threads:[~2023-01-11 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 22:03 [PATCH net-next resubmit v2] r8169: disable ASPM in case of tx timeout Heiner Kallweit
2023-01-11 16:16 ` Alexander H Duyck [this message]
2023-01-11 20:17 ` Heiner Kallweit
2023-01-11 22:38 ` Alexander Duyck
2023-01-11 22:57 ` Heiner Kallweit
2023-01-12 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a709b727f117fbcad7bdd5abccfaa891775dbc65.camel@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.