From: David Ahern <dsahern@kernel.org>
To: Matthias May <matthias.may@westermo.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
nicolas.dichtel@6wind.com, eyal.birger@gmail.com,
linux-kernel@vger.kernel.org, jesse@nicira.com,
pshelar@nicira.com, tgraf@suug.ch
Subject: Re: [PATCH v3 net] geneve: fix TOS inheriting for ipv4
Date: Wed, 3 Aug 2022 09:36:49 -0600 [thread overview]
Message-ID: <a7107bad-cb41-f612-2ff1-a67ab5830865@kernel.org> (raw)
In-Reply-To: <20220802122025.1364123-1-matthias.may@westermo.com>
On 8/2/22 6:20 AM, Matthias May wrote:
> @@ -822,6 +823,7 @@ static struct rtable *geneve_get_v4_rt(struct sk_buff *skb,
> use_cache = false;
> }
> fl4->flowi4_tos = RT_TOS(tos);
Could make this optional with
if (full_tos)
> + *full_tos = tos;
>
> dst_cache = (struct dst_cache *)&info->dst_cache;
> if (use_cache) {
...
> @@ -1137,6 +1140,7 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
> {
> struct ip_tunnel_info *info = skb_tunnel_info(skb);
> struct geneve_dev *geneve = netdev_priv(dev);
> + __u8 full_tos;
> __be16 sport;
>
> if (ip_tunnel_info_af(info) == AF_INET) {
> @@ -1148,7 +1152,8 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
> 1, USHRT_MAX, true);
>
> rt = geneve_get_v4_rt(skb, dev, gs4, &fl4, info,
> - geneve->cfg.info.key.tp_dst, sport);
> + geneve->cfg.info.key.tp_dst, sport,
> + &full_tos);
> if (IS_ERR(rt))
> return PTR_ERR(rt);
>
since this one is not used
prev parent reply other threads:[~2022-08-03 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 12:20 [PATCH v3 net] geneve: fix TOS inheriting for ipv4 Matthias May
2022-08-02 16:43 ` Guillaume Nault
2022-08-03 15:36 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7107bad-cb41-f612-2ff1-a67ab5830865@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=jesse@nicira.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.may@westermo.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.