From: Jiri Slaby <jirislaby@kernel.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Simon Brand <simon.brand@postadigitale.de>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, Dave@mielke.cc
Subject: Re: [PATCH] TIOCSTI: always enable for CAP_SYS_ADMIN
Date: Thu, 13 Jul 2023 08:01:46 +0200 [thread overview]
Message-ID: <a71ee5b3-2d17-e32f-45e1-0c351cdc501b@kernel.org> (raw)
In-Reply-To: <20230710002645.v565c7xq5iddruse@begin>
On 10. 07. 23, 2:26, Samuel Thibault wrote:
> 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled") broke BRLTTY's
> ability to simulate keypresses on the console, thus effectively breaking
> braille keyboards of blind users.
>
> This restores the TIOCSTI feature for CAP_SYS_ADMIN processes, which
> BRLTTY is, thus fixing braille keyboards without re-opening the security
> issue.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Acked-by: Kees Cook <keescook@chromium.org>
> Fixes: 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")
> Cc: stable@vger.kernel.org
Acked-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2023-07-13 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 0:26 [PATCH] TIOCSTI: always enable for CAP_SYS_ADMIN Samuel Thibault
2023-07-13 6:01 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-01 23:59 Samuel Thibault
2023-07-02 0:01 ` kernel test robot
2023-07-03 19:43 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a71ee5b3-2d17-e32f-45e1-0c351cdc501b@kernel.org \
--to=jirislaby@kernel.org \
--cc=Dave@mielke.cc \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=simon.brand@postadigitale.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.