From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Roberts Subject: Re: [PATCH v1 02/10] mm: pass gfp flags and order to vma_alloc_zeroed_movable_folio() Date: Tue, 27 Jun 2023 08:27:24 +0100 Message-ID: References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-3-ryan.roberts@arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-ID: Content-Type: text/plain; charset="windows-1252" To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists On 27/06/2023 03:27, Yu Zhao wrote: > On Mon, Jun 26, 2023 at 11:14=E2=80=AFAM Ryan Roberts wrote: >> >> Allow allocation of large folios with vma_alloc_zeroed_movable_folio(). >> This prepares the ground for large anonymous folios. The generic >> implementation of vma_alloc_zeroed_movable_folio() now uses >> clear_huge_page() to zero the allocated folio since it may now be a >> non-0 order. >> >> Currently the function is always called with order 0 and no extra gfp >> flags, so no functional change intended. But a subsequent commit will >> take advantage of the new parameters to allocate large folios. The extra >> gfp flags will be used to control the reclaim policy. >> >> Signed-off-by: Ryan Roberts >> --- >> arch/alpha/include/asm/page.h | 5 +++-- >> arch/arm64/include/asm/page.h | 3 ++- >> arch/arm64/mm/fault.c | 7 ++++--- >> arch/ia64/include/asm/page.h | 5 +++-- >> arch/m68k/include/asm/page_no.h | 7 ++++--- >> arch/s390/include/asm/page.h | 5 +++-- >> arch/x86/include/asm/page.h | 5 +++-- >> include/linux/highmem.h | 23 +++++++++++++---------- >> mm/memory.c | 5 +++-- >> 9 files changed, 38 insertions(+), 27 deletions(-) >> >> diff --git a/arch/alpha/include/asm/page.h b/arch/alpha/include/asm/page= .h >> index 4db1ebc0ed99..6fc7fe91b6cb 100644 >> --- a/arch/alpha/include/asm/page.h >> +++ b/arch/alpha/include/asm/page.h >> @@ -17,8 +17,9 @@ >> extern void clear_page(void *page); >> #define clear_user_page(page, vaddr, pg) clear_page(page) >> >> -#define vma_alloc_zeroed_movable_folio(vma, vaddr) \ >> - vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, 0, vma, vaddr= , false) >> +#define vma_alloc_zeroed_movable_folio(vma, vaddr, gfp, order) \ >> + vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO | (gfp), \ >> + order, vma, vaddr, false) >=20 > I don't think we need to worry about gfp if we want to make a minimum > series. There would be many discussion points around it, e.g., I > already disagree with what you chose: GFP_TRANSHUGE_LIGHT would be > more suitable than __GFP_NORETRY, and there are even better options > than GFP_TRANSHUGE_LIGHT. OK, but disagreeing about what the GFP flags should be is different from disagreeing about whether we need a mechanism for specifying them. Given I = need to do the changes to add `order` I thought it was sensible to add the gfp f= lags at the same time. I'll follow your advice and remove the gfp flag addition for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99F9C001B0 for ; Tue, 27 Jun 2023 07:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231343AbjF0H2H (ORCPT ); Tue, 27 Jun 2023 03:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbjF0H1m (ORCPT ); Tue, 27 Jun 2023 03:27:42 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4524D1716; Tue, 27 Jun 2023 00:27:30 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8111411FB; Tue, 27 Jun 2023 00:28:13 -0700 (PDT) Received: from [10.57.76.16] (unknown [10.57.76.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 476E23F663; Tue, 27 Jun 2023 00:27:26 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 08:27:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 02/10] mm: pass gfp flags and order to vma_alloc_zeroed_movable_folio() To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ia64@vger.kernel.org On 27/06/2023 03:27, Yu Zhao wrote: > On Mon, Jun 26, 2023 at 11:14 AM Ryan Roberts wrote: >> >> Allow allocation of large folios with vma_alloc_zeroed_movable_folio(). >> This prepares the ground for large anonymous folios. The generic >> implementation of vma_alloc_zeroed_movable_folio() now uses >> clear_huge_page() to zero the allocated folio since it may now be a >> non-0 order. >> >> Currently the function is always called with order 0 and no extra gfp >> flags, so no functional change intended. But a subsequent commit will >> take advantage of the new parameters to allocate large folios. The extra >> gfp flags will be used to control the reclaim policy. >> >> Signed-off-by: Ryan Roberts >> --- >> arch/alpha/include/asm/page.h | 5 +++-- >> arch/arm64/include/asm/page.h | 3 ++- >> arch/arm64/mm/fault.c | 7 ++++--- >> arch/ia64/include/asm/page.h | 5 +++-- >> arch/m68k/include/asm/page_no.h | 7 ++++--- >> arch/s390/include/asm/page.h | 5 +++-- >> arch/x86/include/asm/page.h | 5 +++-- >> include/linux/highmem.h | 23 +++++++++++++---------- >> mm/memory.c | 5 +++-- >> 9 files changed, 38 insertions(+), 27 deletions(-) >> >> diff --git a/arch/alpha/include/asm/page.h b/arch/alpha/include/asm/page.h >> index 4db1ebc0ed99..6fc7fe91b6cb 100644 >> --- a/arch/alpha/include/asm/page.h >> +++ b/arch/alpha/include/asm/page.h >> @@ -17,8 +17,9 @@ >> extern void clear_page(void *page); >> #define clear_user_page(page, vaddr, pg) clear_page(page) >> >> -#define vma_alloc_zeroed_movable_folio(vma, vaddr) \ >> - vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, 0, vma, vaddr, false) >> +#define vma_alloc_zeroed_movable_folio(vma, vaddr, gfp, order) \ >> + vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO | (gfp), \ >> + order, vma, vaddr, false) > > I don't think we need to worry about gfp if we want to make a minimum > series. There would be many discussion points around it, e.g., I > already disagree with what you chose: GFP_TRANSHUGE_LIGHT would be > more suitable than __GFP_NORETRY, and there are even better options > than GFP_TRANSHUGE_LIGHT. OK, but disagreeing about what the GFP flags should be is different from disagreeing about whether we need a mechanism for specifying them. Given I need to do the changes to add `order` I thought it was sensible to add the gfp flags at the same time. I'll follow your advice and remove the gfp flag addition for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 797D7EB64D9 for ; Tue, 27 Jun 2023 07:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5kW5MddS0Ugiqg4oflFjs3Un8ojpM+YALMZKF+Pd6AA=; b=4XTAJwanFBhJAi +y0CwZ42A7AwQWesG8yAGHvImFOK/XFm4dNw6kLi1VNpLTRI7ec26MGjXkgmIkjSwoQ1KbAh9ymhm qYmXkTDzCbGMZP4CtaMH7aVMQ6zRE7NgWp/dAHFZWYOnYH+j8ctppsKxF09lPCaejqPT0w6uJbc8I WvQBxYo2Ts0B+Pm+6ELjMasHgrZtLZdPVbd8nrnzkQc8lOGiL9n39BuRlCzMrf7fwTcAZ/tMcmOPL e4Tfagpm1yvbFIehNEdJkAtLqUA0MiJKpi+eugRI9QuUG9ibG3fbNrUfEkocKWFfVlnUm3hMZjE7L a0FuPkpCItdFfszAtU8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE36t-00CLjQ-1M; Tue, 27 Jun 2023 07:27:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE36p-00CLhI-2t for linux-arm-kernel@lists.infradead.org; Tue, 27 Jun 2023 07:27:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8111411FB; Tue, 27 Jun 2023 00:28:13 -0700 (PDT) Received: from [10.57.76.16] (unknown [10.57.76.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 476E23F663; Tue, 27 Jun 2023 00:27:26 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 08:27:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 02/10] mm: pass gfp flags and order to vma_alloc_zeroed_movable_folio() To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_002732_030242_B606E225 X-CRM114-Status: GOOD ( 21.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjcvMDYvMjAyMyAwMzoyNywgWXUgWmhhbyB3cm90ZToKPiBPbiBNb24sIEp1biAyNiwgMjAy MyBhdCAxMToxNOKAr0FNIFJ5YW4gUm9iZXJ0cyA8cnlhbi5yb2JlcnRzQGFybS5jb20+IHdyb3Rl Ogo+Pgo+PiBBbGxvdyBhbGxvY2F0aW9uIG9mIGxhcmdlIGZvbGlvcyB3aXRoIHZtYV9hbGxvY196 ZXJvZWRfbW92YWJsZV9mb2xpbygpLgo+PiBUaGlzIHByZXBhcmVzIHRoZSBncm91bmQgZm9yIGxh cmdlIGFub255bW91cyBmb2xpb3MuIFRoZSBnZW5lcmljCj4+IGltcGxlbWVudGF0aW9uIG9mIHZt YV9hbGxvY196ZXJvZWRfbW92YWJsZV9mb2xpbygpIG5vdyB1c2VzCj4+IGNsZWFyX2h1Z2VfcGFn ZSgpIHRvIHplcm8gdGhlIGFsbG9jYXRlZCBmb2xpbyBzaW5jZSBpdCBtYXkgbm93IGJlIGEKPj4g bm9uLTAgb3JkZXIuCj4+Cj4+IEN1cnJlbnRseSB0aGUgZnVuY3Rpb24gaXMgYWx3YXlzIGNhbGxl ZCB3aXRoIG9yZGVyIDAgYW5kIG5vIGV4dHJhIGdmcAo+PiBmbGFncywgc28gbm8gZnVuY3Rpb25h bCBjaGFuZ2UgaW50ZW5kZWQuIEJ1dCBhIHN1YnNlcXVlbnQgY29tbWl0IHdpbGwKPj4gdGFrZSBh ZHZhbnRhZ2Ugb2YgdGhlIG5ldyBwYXJhbWV0ZXJzIHRvIGFsbG9jYXRlIGxhcmdlIGZvbGlvcy4g VGhlIGV4dHJhCj4+IGdmcCBmbGFncyB3aWxsIGJlIHVzZWQgdG8gY29udHJvbCB0aGUgcmVjbGFp bSBwb2xpY3kuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFJ5YW4gUm9iZXJ0cyA8cnlhbi5yb2JlcnRz QGFybS5jb20+Cj4+IC0tLQo+PiAgYXJjaC9hbHBoYS9pbmNsdWRlL2FzbS9wYWdlLmggICB8ICA1 ICsrKy0tCj4+ICBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL3BhZ2UuaCAgIHwgIDMgKystCj4+ICBh cmNoL2FybTY0L21tL2ZhdWx0LmMgICAgICAgICAgIHwgIDcgKysrKy0tLQo+PiAgYXJjaC9pYTY0 L2luY2x1ZGUvYXNtL3BhZ2UuaCAgICB8ICA1ICsrKy0tCj4+ICBhcmNoL202OGsvaW5jbHVkZS9h c20vcGFnZV9uby5oIHwgIDcgKysrKy0tLQo+PiAgYXJjaC9zMzkwL2luY2x1ZGUvYXNtL3BhZ2Uu aCAgICB8ICA1ICsrKy0tCj4+ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9wYWdlLmggICAgIHwgIDUg KysrLS0KPj4gIGluY2x1ZGUvbGludXgvaGlnaG1lbS5oICAgICAgICAgfCAyMyArKysrKysrKysr KysrLS0tLS0tLS0tLQo+PiAgbW0vbWVtb3J5LmMgICAgICAgICAgICAgICAgICAgICB8ICA1ICsr Ky0tCj4+ICA5IGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygt KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hbHBoYS9pbmNsdWRlL2FzbS9wYWdlLmggYi9hcmNo L2FscGhhL2luY2x1ZGUvYXNtL3BhZ2UuaAo+PiBpbmRleCA0ZGIxZWJjMGVkOTkuLjZmYzdmZTkx YjZjYiAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hbHBoYS9pbmNsdWRlL2FzbS9wYWdlLmgKPj4gKysr IGIvYXJjaC9hbHBoYS9pbmNsdWRlL2FzbS9wYWdlLmgKPj4gQEAgLTE3LDggKzE3LDkgQEAKPj4g IGV4dGVybiB2b2lkIGNsZWFyX3BhZ2Uodm9pZCAqcGFnZSk7Cj4+ICAjZGVmaW5lIGNsZWFyX3Vz ZXJfcGFnZShwYWdlLCB2YWRkciwgcGcpICAgICAgIGNsZWFyX3BhZ2UocGFnZSkKPj4KPj4gLSNk ZWZpbmUgdm1hX2FsbG9jX3plcm9lZF9tb3ZhYmxlX2ZvbGlvKHZtYSwgdmFkZHIpIFwKPj4gLSAg ICAgICB2bWFfYWxsb2NfZm9saW8oR0ZQX0hJR0hVU0VSX01PVkFCTEUgfCBfX0dGUF9aRVJPLCAw LCB2bWEsIHZhZGRyLCBmYWxzZSkKPj4gKyNkZWZpbmUgdm1hX2FsbG9jX3plcm9lZF9tb3ZhYmxl X2ZvbGlvKHZtYSwgdmFkZHIsIGdmcCwgb3JkZXIpIFwKPj4gKyAgICAgICB2bWFfYWxsb2NfZm9s aW8oR0ZQX0hJR0hVU0VSX01PVkFCTEUgfCBfX0dGUF9aRVJPIHwgKGdmcCksIFwKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgb3JkZXIsIHZtYSwgdmFkZHIsIGZhbHNlKQo+IAo+IEkgZG9uJ3Qg dGhpbmsgd2UgbmVlZCB0byB3b3JyeSBhYm91dCBnZnAgaWYgd2Ugd2FudCB0byBtYWtlIGEgbWlu aW11bQo+IHNlcmllcy4gVGhlcmUgd291bGQgYmUgbWFueSBkaXNjdXNzaW9uIHBvaW50cyBhcm91 bmQgaXQsIGUuZy4sIEkKPiBhbHJlYWR5IGRpc2FncmVlIHdpdGggd2hhdCB5b3UgY2hvc2U6IEdG UF9UUkFOU0hVR0VfTElHSFQgd291bGQgYmUKPiBtb3JlIHN1aXRhYmxlIHRoYW4gX19HRlBfTk9S RVRSWSwgYW5kIHRoZXJlIGFyZSBldmVuIGJldHRlciBvcHRpb25zCj4gdGhhbiBHRlBfVFJBTlNI VUdFX0xJR0hULgoKT0ssIGJ1dCBkaXNhZ3JlZWluZyBhYm91dCB3aGF0IHRoZSBHRlAgZmxhZ3Mg c2hvdWxkIGJlIGlzIGRpZmZlcmVudCBmcm9tCmRpc2FncmVlaW5nIGFib3V0IHdoZXRoZXIgd2Ug bmVlZCBhIG1lY2hhbmlzbSBmb3Igc3BlY2lmeWluZyB0aGVtLiBHaXZlbiBJIG5lZWQKdG8gZG8g dGhlIGNoYW5nZXMgdG8gYWRkIGBvcmRlcmAgSSB0aG91Z2h0IGl0IHdhcyBzZW5zaWJsZSB0byBh ZGQgdGhlIGdmcCBmbGFncwphdCB0aGUgc2FtZSB0aW1lLgoKSSdsbCBmb2xsb3cgeW91ciBhZHZp Y2UgYW5kIHJlbW92ZSB0aGUgZ2ZwIGZsYWcgYWRkaXRpb24gZm9yIG5vdy4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK