Re: [PATCH] vdpa/mlx5: fix unregister kick handler order

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 8/8/23 13:32, Yajun Wu wrote:
> The mlx5_vdpa_virtq_kick_handler function may still be running and waiting
> on virtq->virtq_lock while mlx5_vdpa_cqe_event_unset function is trying to
> re-initialize the virtq->virtq_lock.
> 
> This causes mlx5_vdpa_virtq_kick_handler thread can't be wake up and can't
> be unregister. Following print may loop forever when calling
> rte_vhost_driver_unregister(socket_path):
> 
>      mlx5_vdpa: Try again to unregister fd 154 of virtq 11 interrupt
>      mlx5_vdpa: Try again to unregister fd 154 of virtq 11 interrupt
>      ...
> 
> The fix is to move mlx5_vdpa_virtq_unregister_intr_handle before
> mlx5_vdpa_cqe_event_unset.
> 
> Fixes: 057f7d2084 ("vdpa/mlx5: optimize datapath-control synchronization")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yajun Wu <yajunw@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>   drivers/vdpa/mlx5/mlx5_vdpa.c         | 1 +
>   drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 1 -
>   2 files changed, 1 insertion(+), 1 deletion(-)


Applied to nex-virtio/for-next-net.

Thanks,
Maxime