From: Denis Efremov <efremov@linux.com>
To: Colin King <colin.king@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Willy Tarreau <w@1wt.eu>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy: remove redundant assignment to variable st
Date: Fri, 16 Apr 2021 10:34:12 +0300 [thread overview]
Message-ID: <a732fe0b-217b-084b-eecb-ccbc21cbbfc9@linux.com> (raw)
In-Reply-To: <20210415130020.1959951-1-colin.king@canonical.com>
Hi,
On 4/15/21 4:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable st is being assigned a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks!
https://github.com/evdenis/linux-floppy/commit/aeec7983d49a5f972df47c742ff8373df15b0d28
> ---
> arch/x86/include/asm/floppy.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h
> index d43717b423cb..6ec3fc969ad5 100644
> --- a/arch/x86/include/asm/floppy.h
> +++ b/arch/x86/include/asm/floppy.h
> @@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)
> int lcount;
> char *lptr;
>
> - st = 1;
> for (lcount = virtual_dma_count, lptr = virtual_dma_addr;
> lcount; lcount--, lptr++) {
> st = inb(virtual_dma_port + FD_STATUS);
>
next prev parent reply other threads:[~2021-04-16 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:00 [PATCH] floppy: remove redundant assignment to variable st Colin King
2021-04-15 13:21 ` Willy Tarreau
2021-04-16 7:34 ` Denis Efremov [this message]
2021-04-16 12:29 ` Denis Efremov
2021-04-16 12:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a732fe0b-217b-084b-eecb-ccbc21cbbfc9@linux.com \
--to=efremov@linux.com \
--cc=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=w@1wt.eu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.