Re: [PULL 2/8] tests/qtest/ide-test: parametrize the ATAPI CD-ROM read test

[Thomas Huth <thuth@redhat.com>]

On 30/07/2026 10.13, Denis V. Lunev wrote:
> cdrom_pio_impl() and test_cdrom_dma() duplicate the same image setup
> and data-integrity check around two different transfer mechanisms.
> Fold them into a single cdrom_read_impl(nblocks, flags) helper, with a
> CDROM_PIO/CDROM_DMA flag selecting the transfer, so further read
> coverage can be added once for both paths.
> 
> No functional change: /ide/cdrom/pio, pio_large and dma run exactly
> as before.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> ---
>   tests/qtest/ide-test.c | 146 +++++++++++++++++++----------------------
>   1 file changed, 68 insertions(+), 78 deletions(-)
> 
> diff --git a/tests/qtest/ide-test.c b/tests/qtest/ide-test.c
> index 721e78170b..0fcfd0688c 100644
> --- a/tests/qtest/ide-test.c
> +++ b/tests/qtest/ide-test.c
> @@ -982,6 +982,7 @@ static void send_scsi_cdb_read10(QPCIDevice *dev, QPCIBar ide_bar,
>       }
>   }
>   
> +
>   static void nsleep(QTestState *qts, int64_t nsecs)
>   {
>       const struct timespec val = { .tv_nsec = nsecs };
The above hunk introduces a white space damage. Please drop it.

  Thanks,
   Thomas