From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F251C7EE2E for ; Tue, 13 Jun 2023 02:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbjFMCKT (ORCPT ); Mon, 12 Jun 2023 22:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234698AbjFMCKS (ORCPT ); Mon, 12 Jun 2023 22:10:18 -0400 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF6B5131 for ; Mon, 12 Jun 2023 19:10:16 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=chengyou@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Vl00bxu_1686622212; Received: from 30.221.101.46(mailfrom:chengyou@linux.alibaba.com fp:SMTPD_---0Vl00bxu_1686622212) by smtp.aliyun-inc.com; Tue, 13 Jun 2023 10:10:13 +0800 Message-ID: Date: Tue, 13 Jun 2023 10:10:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH for-next 0/4] RDMA/erdma: Add a new doorbell allocation mechanism Content-Language: en-US To: Leon Romanovsky Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, KaiShen@linux.alibaba.com References: <20230606055005.80729-1-chengyou@linux.alibaba.com> <20230611091936.GB12152@unreal> From: Cheng Xu In-Reply-To: <20230611091936.GB12152@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 6/11/23 5:19 PM, Leon Romanovsky wrote: > On Tue, Jun 06, 2023 at 01:50:01PM +0800, Cheng Xu wrote: >> Hi, >> >> This series adds a new doorbell allocation mechanism to meet the >> the isolation requirement for userspace applications. Two main change >> points in this patch set: One is that we extend the bar space for doorbell >> allocation, and the other one is that we associate QPs/CQs with the >> allocated doorbells for authorization. We also keep the original doorbell >> mechanism for compatibility, but only used under CAP_SYS_RAWIO to prevent >> non-privileged access, which suggested by Jason before. >> >> - #1 configures the current PAGE_SIZE to hardware, so that hardware can >> organize the mmio space properly. >> - #2~#3 implement the new doorbell allocation mechanism. >> - #4 refactors the doorbell allocation part to make code more simpler and >> cleaner. >> >> Thanks, >> Cheng Xu >> >> Cheng Xu (4): >> RDMA/erdma: Configure PAGE_SIZE to hardware >> RDMA/erdma: Allocate doorbell resources from hardware >> RDMA/erdma: Associate QPs/CQs with doorbells for authorization >> RDMA/erdma: Refactor the original doorbell allocation mechanism > > As a side note, there is no need to perform double not (!!...) when > assigning to bool variables. > Get it. I will address it in future patchset together with other cleaning up. Thanks, Cheng Xu