All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kashyap Desai <kashyap.desai@broadcom.com>
To: linux-scsi@vger.kernel.org, Peter Rivera <peter.rivera@broadcom.com>
Subject: RE: [RFC 0/2] mpt3sas/megaraid_sas : irq poll and load balancing of reply queue
Date: Mon, 22 Jan 2018 17:03:15 +0530	[thread overview]
Message-ID: <a75d5260fff6377ce193c7f417e8052f@mail.gmail.com> (raw)
In-Reply-To: 92d894a263bf37152fdae9699ccaccff@mail.gmail.com

>
> In Summary,
> CPU completing IO which is not contributing to IO submission, may cause
cpu
> lockup.
> If CPUs count to MSI-X vector count ratio is X:1 (where X > 1) then
using irq poll
> interface, we can avoid the CPU lockups and by equally distributing the
> interrupts among the enabled MSI-x interrupts we can avoid performance
> issues.
>
> We are planning to use both the fixes only if cpu count is more than FW
> supported MSI-x vector.
> Please review and provide your feedback. I have appended both the
patches.

Hi -
Assuming method explained here is in-line with Linux SCSI subsystem and
there is no better method to fix such issue.
I am planning to provide the same solution for internal testing and
maintainers of respective driver (mpt3sas and megaraid_sas) will post
final patch to the upstream based on results.
As of now PoC results looks promising with the above mentioned solution
and no cpu lock was discovered.

>
> Thanks, Kashyap
>
>

             reply	other threads:[~2018-01-22 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 11:33 Kashyap Desai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-01-15 12:12 [RFC 0/2] mpt3sas/megaraid_sas : irq poll and load balancing of reply queue Kashyap Desai
2018-01-29  8:59 ` Hannes Reinecke
2018-01-29 16:52   ` Kashyap Desai
2018-02-02 10:13 ` Ming Lei
2018-02-02 11:38   ` Kashyap Desai
2018-02-02 12:52     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a75d5260fff6377ce193c7f417e8052f@mail.gmail.com \
    --to=kashyap.desai@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=peter.rivera@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.