From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:5f65:b0:1be9:327d:8ee3 with SMTP id gl5csp3124680njc; Wed, 26 Mar 2025 00:05:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUcLwMroDZ9mvrzpxxB22tgV4TGuHSL5G+rK84r5corw4ZCbpOYgItJfCdQq9LOmMPzELMqbfi54D6fjg==@linaro.org X-Google-Smtp-Source: AGHT+IHeXwxPBVqrhswDsW8Q9crjDtFVQoKkP8WbVxm1AN8GRyKCRSDSC+oyIid7vX+3d7KBQyOZ X-Received: by 2002:a05:622a:1f1b:b0:477:d00:b448 with SMTP id d75a77b69052e-4771de5cc42mr263400431cf.40.1742972756204; Wed, 26 Mar 2025 00:05:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742972756; cv=none; d=google.com; s=arc-20240605; b=KH37EhjDhOJhYa7q4B7dZkTgdNtQDUM5CkjxvOzZQinVOCrNEVc8lowopifpZ+u6ZU AzkXVHm/QW4Jb/pi+8byg/A/w4SlGeevoGEEjoZLXLYAvt+oPw3JNWSgCLGVaxL0c5M6 7b3wwd0C4kuPpuei2e1sD45Po7795lOyVAvAbiuiMnBYhejWaFH+K5du+IrufC2t49Mk HT4hZjLAeaXbU2BlMdmxtfQnfeDMbjK/ecptaBjQAv0v6HPNA+yhaMOfvEE3vtr4pbX6 OyoSnlI1GBy4cv9/UaKmqxz8JO62qS4kuJ8omGNy3QrbA223DJQ5qfi+q9is9RucgmVI R6BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:content-language:from:references:cc:to :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=8ewda+j49KTLZp8UhkcRZM4IEhymR7GVcd/m3pJlytE=; fh=BmqU85sQxrKeuLQxaOZH3TYjlknCD6Xu9m6wedFySlA=; b=gco62788i3lh3xUgA8ymyFpYyKmM8eaSyUk6ToYJ9saDWYJM7pntW7kN9fRiARo/Ag d198/avvLGdeWeck8lsnqCrTsuS4kS6TdsOvhqKxeOCQyEiDpEcOhRwkmp0MUeVyzp8z ltei8wgYUC0DSAF6fzDbciRW3gVo91AUCNyBc8nNrBYyFWpkEHMGcpPWe+K+3wJhgBpt b2Z3nn0Qkey8XzomAuxBkAjuYaAUp+NLt1hQNdNO3AovNo35wHQVMqOgwMaeNUHaaF1d XSrtxY87zamwX1kYqH4FSQSyUdjbnvPe+0hdrlgMiQko70cnWq24pbZdrOvK1zi4CMGC tgmA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="OfjXX/Js"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4771d4fe6a2si107418451cf.283.2025.03.26.00.05.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Mar 2025 00:05:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="OfjXX/Js"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1txKpd-0001JI-VM; Wed, 26 Mar 2025 03:05:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txKpS-000142-Hr for qemu-devel@nongnu.org; Wed, 26 Mar 2025 03:05:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txKpP-0008KO-Rv for qemu-devel@nongnu.org; Wed, 26 Mar 2025 03:05:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742972731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8ewda+j49KTLZp8UhkcRZM4IEhymR7GVcd/m3pJlytE=; b=OfjXX/JsUuH2EpSFcq8WjJmDr6Clg0ou+GhYysggvBpqmggFVnkXGXAga8ksKfVhRTJQD/ +GhrD0tKu4F59z5X9ZKyT7Rk3YuH7zrhKTEjZveAPrjR7zSvVLxF+tUq2hiVCmHPY7Y4Sq EJ3on0NvmdCkPsMf7lWqkFQPCp4nj10= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-tWp3TW-LN3OcnthMQHLIzg-1; Wed, 26 Mar 2025 03:05:29 -0400 X-MC-Unique: tWp3TW-LN3OcnthMQHLIzg-1 X-Mimecast-MFC-AGG-ID: tWp3TW-LN3OcnthMQHLIzg_1742972728 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cec217977so1654795e9.0 for ; Wed, 26 Mar 2025 00:05:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742972728; x=1743577528; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ewda+j49KTLZp8UhkcRZM4IEhymR7GVcd/m3pJlytE=; b=WAwcyoalOh9IkIxfB7/pdmVLmI/wfUJiUYEV3yoRIj/KpLT15DJpjNAWLP+iDXB0PB riR99MRlSAee1DlIB5WRt4Kj+zahAWkGa5en/Gx0E4rUQy0wmc6iiWwl1WHmPNbO3Lcj GuzD45uLGgbPeCO7dprSQepi6LIIUAf7ebi75XwuyQPbpY8BQjFAf4uO1OcARxVUdhFo rDgq35KrAFaMRgMPJ4jdzf1cKVUOOnhbFQ2gSuRMCg8fMVT+1zE3azq/npdmH5hx769d ryTqV2TqXrOg2t+Sjod/JvwmlU4dVTCePcRmZ+sdO0bg2N6xHtgZfUtkkdPy9EQPaqxi He9w== X-Forwarded-Encrypted: i=1; AJvYcCWlv2X2p3vr8lzrXa2lBa/5KeWGvP6jTs+AHiMhQ3wNYlU9kHx0dYhXa/G2tleoGqRgdwQwNUGAL9Wb@nongnu.org X-Gm-Message-State: AOJu0YzgasOX+edUTb5+syj5Sck3jzWgH06B+UKY6YKDtQZyOnUpZPNJ 3zhRpWkWmuSq59sWB/h/sHJDHQKiB67t6gTG4ZvytVptzBT8ucGEmLEnLj732akOgzOShx9bg1h X1FgYtuqVvRRvpOmTLd7RxLbyzJJTwAJW7BGP3DXFY94fTgkhbjDY X-Gm-Gg: ASbGncvUkcw5tZQ3PzcRYjTeBCnis2yBIOE7XUhdJaAoX5LgpGmMSgYpOF4iIKBZ+0e CBh6lHstSh48rj9WraHyUmBcj4v3xIDyziafD/B64/g8h8A1YJl7dCY+XPD11n1cVzff/K400hb MpLyiZkzyKN5lAVoN9QU/RIxkMwnTwQM1vd83kgO/602ZRFsOux8l8YepRIlHIp872xjlTVNYhY EnFHn2HxKf8DLdKuNEl1sYA0079W5gn46QNamicKCvABHPVQV8c5RNCwYm0ZzR2sZMyWB6XV2A9 K+0zEF8jDVx5s6BupLOo88A9GJjCZLgS89DrUPD0GH/e1Uk= X-Received: by 2002:a05:600c:299:b0:43d:94:cfe6 with SMTP id 5b1f17b1804b1-43d509f5a52mr146480415e9.16.1742972728275; Wed, 26 Mar 2025 00:05:28 -0700 (PDT) X-Received: by 2002:a05:600c:299:b0:43d:94:cfe6 with SMTP id 5b1f17b1804b1-43d509f5a52mr146479995e9.16.1742972727757; Wed, 26 Mar 2025 00:05:27 -0700 (PDT) Received: from [192.168.0.7] (ip-109-43-49-206.web.vodafone.de. [109.43.49.206]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f43cbasm222391585e9.9.2025.03.26.00.05.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Mar 2025 00:05:27 -0700 (PDT) Message-ID: Date: Wed, 26 Mar 2025 08:05:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-10.0 05/12] hw/gpio/pca9552: Categorize and add description To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Ilya Leoshkevich , BALATON Zoltan , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Matthew Rosato , Gerd Hoffmann , Glenn Miles , Samuel Tardieu , qemu-block@nongnu.org, Patrick Leis , David Hildenbrand , "Edgar E. Iglesias" , Tyrone Ting , Eric Farman , Christian Borntraeger , Peter Maydell , Halil Pasic , Richard Henderson , Kevin Wolf , Alistair Francis , Bernhard Beschow , Hanna Reitz , Hao Wu , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org References: <20250325224310.8785-1-philmd@linaro.org> <20250325224310.8785-6-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250325224310.8785-6-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: WrR+lFGumQPU On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/gpio/pca9552.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c > index 1ac0cf6c464..b152872f6c6 100644 > --- a/hw/gpio/pca9552.c > +++ b/hw/gpio/pca9552.c > @@ -459,6 +459,8 @@ static void pca9552_class_init(ObjectClass *oc, void *data) > DeviceClass *dc = DEVICE_CLASS(oc); > PCA955xClass *pc = PCA955X_CLASS(oc); > > + dc->desc = "PCA9552 LED blinker"; > + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > device_class_set_legacy_reset(dc, pca9552_reset); > dc->vmsd = &pca9552_vmstate; > pc->max_reg = PCA9552_LS3; I2C device - same problem as in patch 1 : Unset MISC category here? Thomas