Re: Recent changes (master)

[Vincent Fu <vincentfu@gmail.com>]

On 6/4/24 08:11, Niklas Cassel wrote:
> On Tue, Jun 04, 2024 at 06:00:01AM -0600, Jens Axboe wrote:
>> The following changes since commit 93dc85482a998440f8e40814014da8cbfe9cf5e8:
>>
>>    Merge branch 'fix-coverity-scan-defect' of https://github.com/parkvibes/fio (2024-05-31 09:46:59 -0400)
>>
>> are available in the Git repository at:
>>
>>    git://git.kernel.dk/fio.git master
>>
>> for you to fetch changes up to 1757469a81cac5bd662b9cde26f1e5d4f0402181:
>>
>>    Merge branch 'io_uring_cmd/support-write-family' of https://github.com/samsungds/fio (2024-06-03 10:17:38 -0400)
>>
>> ----------------------------------------------------------------
>> Minwoo Im (1):
>>        io_uring: Add 'write_mode' option for optional cmds
>>
>> Vincent Fu (1):
>>        Merge branch 'io_uring_cmd/support-write-family' of https://github.com/samsungds/fio
>>
>>   HOWTO.rst          | 16 ++++++++++++++
>>   engines/io_uring.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>   engines/nvme.c     |  4 ++--
>>   engines/nvme.h     |  5 ++++-
>>   fio.1              | 20 +++++++++++++++++
>>   5 files changed, 105 insertions(+), 4 deletions(-)
>>
>> ---
>>
>> Diff of recent changes:
>>
>> diff --git a/HOWTO.rst b/HOWTO.rst
>> index 0b39a892..33a6ad93 100644
>> --- a/HOWTO.rst
>> +++ b/HOWTO.rst
>> @@ -2857,6 +2857,22 @@ with the caveat that when used on the command line, they must come after the
>>   	With writefua option set to 1, write operations include
>>   	the force unit access (fua) flag. Default is 0.
>>   
>> +.. option:: write_mode=str : [io_uring_cmd]
>> +
>> +        Specifies the type of write operation.  Defaults to 'write'.
>> +
>> +                **write**
>> +                        Use Write commands for write operations
>> +
>> +                **uncor**
>> +                        Use Write Uncorrectable commands for write opreations
> 
> FWIW: s/opreations/operations/
> 
> 
> 
>> diff --git a/fio.1 b/fio.1
>> index 9a965cb0..2649529b 100644
>> --- a/fio.1
>> +++ b/fio.1
>> @@ -2640,6 +2640,26 @@ unit access (fua) flag. Default: 0.
>>   With writefua option set to 1, write operations include the force
>>   unit access (fua) flag. Default: 0.
>>   .TP
>> +.BI (io_uring_cmd)write_mode \fR=\fPstr
>> +Specifies the type of write operation.  Defaults to 'write'.
>> +.RS
>> +.RS
>> +.TP
>> +.B write
>> +Use Write commands for write operations
>> +.TP
>> +.B uncor
>> +Use Write Uncorrectable commands for write opreations
> 
> FWIW: s/opreations/operations/
> 
> 
> Kind regards,
> Niklas
> 

Fixed. Thanks.

Vincent