Re: [PATCH v2 1/2] fuse: use default writeback accounting

[David Hildenbrand <david@redhat.com>]

On 09.07.25 13:06, Bernd Schubert wrote:
> 
> 
> On 7/8/25 01:46, Joanne Koong wrote:
>> commit 0c58a97f919c ("fuse: remove tmp folio for writebacks and internal
>> rb tree") removed temp folios for dirty page writeback. Consequently,
>> fuse can now use the default writeback accounting.
>>
>> With switching fuse to use default writeback accounting, there are some
>> added benefits. This updates wb->writeback_inodes tracking as well now
>> and updates writeback throughput estimates after writeback completion.
>>
>> This commit also removes inc_wb_stat() and dec_wb_stat(). These have no
>> callers anymore now that fuse does not call them.
>>
>> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
>> ---
>>   fs/fuse/file.c              |  9 +--------
>>   fs/fuse/inode.c             |  2 --
>>   include/linux/backing-dev.h | 10 ----------
>>   3 files changed, 1 insertion(+), 20 deletions(-)
>>
>> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
>> index adc4aa6810f5..e53331c851eb 100644
>> --- a/fs/fuse/file.c
>> +++ b/fs/fuse/file.c
>> @@ -1784,19 +1784,15 @@ static void fuse_writepage_finish(struct fuse_writepage_args *wpa)
>>   	struct fuse_args_pages *ap = &wpa->ia.ap;
>>   	struct inode *inode = wpa->inode;
>>   	struct fuse_inode *fi = get_fuse_inode(inode);
>> -	struct backing_dev_info *bdi = inode_to_bdi(inode);
>>   	int i;
>>   
>> -	for (i = 0; i < ap->num_folios; i++) {
>> +	for (i = 0; i < ap->num_folios; i++)
>>   		/*
>>   		 * Benchmarks showed that ending writeback within the
>>   		 * scope of the fi->lock alleviates xarray lock
>>   		 * contention and noticeably improves performance.
>>   		 */
>>   		folio_end_writeback(ap->folios[i]);
>> -		dec_wb_stat(&bdi->wb, WB_WRITEBACK);
>> -		wb_writeout_inc(&bdi->wb);
>> -	}
> 
> Probably, just my own style, personally I keep the braces when there are
> comments.

Yeah, sometimes it can aid readability. I tend to keep them on 
multi-line comments IIRC.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb