All of lore.kernel.org
 help / color / mirror / Atom feed
From: "kylezhao(赵柯宇)" <kylezhao@tencent.com>
To: Jiang Xin <worldhello.net@gmail.com>,
	Taylor Blau <me@ttaylorr.com>, "Git List" <git@vger.kernel.org>
Cc: Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: RE: [Internet][PATCH] t5516: fail to run in verbose mode
Date: Tue, 22 Nov 2022 02:22:35 +0000	[thread overview]
Message-ID: <a7abaa2cc8d248faa50ad95fc3670ee0@tencent.com> (raw)
In-Reply-To: <20221121134040.12260-1-worldhello.net@gmail.com>

> The test case "push with config push.useBitmap" of t5516 was introduced in
> commit 82f67ee13f (send-pack.c: add config push.useBitmaps, 2022-06-17). It
> won't work in verbose mode, e.g.:
> 
>     $ sh t5516-fetch-push.sh --run='1,115' -v
> 
> This is because "git-push" will run in a tty in this case, and the subcommand
> "git pack-objects" will contain an argument "--progress"
> instead of "-q". Adding a specific option "--quiet" to "git push" will get a stable
> result for t5516.
> 

That's true. Thanks for noticing and fixing.

I didn't consider this usage of test case, and it works after your patch.

Thanks,
Kyle

  reply	other threads:[~2022-11-22  2:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 13:40 [PATCH] t5516: fail to run in verbose mode Jiang Xin
2022-11-22  2:22 ` kylezhao(赵柯宇) [this message]
2022-11-22  4:19 ` Junio C Hamano
2022-11-22 19:08   ` Jeff King
2022-11-23  1:17     ` Junio C Hamano
2022-11-24  1:16       ` Jeff King
2022-11-25  4:58         ` Junio C Hamano
2022-11-28  5:13           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7abaa2cc8d248faa50ad95fc3670ee0@tencent.com \
    --to=kylezhao@tencent.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=worldhello.net@gmail.com \
    --cc=zhiyou.jx@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.