All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: "Clément Le Goffic" <clegoffic@baylibre.com>,
	"Kernel.org Tools" <tools@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH b4] config: accept prep-pre-flight-checks from .b4-config
Date: Fri, 10 Jul 2026 17:51:10 +0200	[thread overview]
Message-ID: <a7e019e7-584f-4be4-bf15-c3ac51be8edc@kernel.org> (raw)
In-Reply-To: <20260710-b4-config-pre-flight-checks-v1-1-ab16cf14a00c@baylibre.com>

Hi Clément,

On 10/07/2026 17:14, Clément Le Goffic wrote:
> The .b4-config file is a convenient way to share project-level b4
> configuration among contributors via version control.  However, only
> keys matching a set of glob patterns are currently accepted from it
> (see wtglobs in _setup_main_config).
> 
> The prep-pre-flight-checks key, which controls which pre-flight
> checks are enabled or disabled before sending a series, is not
> matched by any of the existing patterns.  The closest glob,
> 'prep-*-check-cmd', only matches keys ending in '-check-cmd', not
> '-checks'.  As a result, setting prep-pre-flight-checks in
> .b4-config has no effect: the value is silently dropped and the
> default 'enable-all' is used instead.
> 
> Add 'prep-pre-flight-checks' to the wtglobs list so it can be set
> from .b4-config, allowing projects to disable checks (e.g.
> needs-checking, needs-auto-to-cc) that are not relevant to their
> workflow and share that decision via version control.
I don't remember if it was present in this list for security reasons --
similar to *-check-cmd at some points [1] -- but I do remember a bug
report with the same patch [2] which has never been applied.

On my side, I think it would be useful to be able to use
"disable-needs-auto-to-cc" on some specific dev tree of a
"sub-subsystem". On these dev branches, no need to add extra reviewers
from the "parent" subsystem.

We could then have this config:

    [b4]
        send-series-to = <dev ML>
        prep-pre-flight-checks = disable-needs-auto-to-cc
        send-prefixes = <specific dev prefix>

[1] https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=a1360385
[2] https://bugzilla.kernel.org/show_bug.cgi?id=219705

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2026-07-10 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 15:14 [PATCH b4] config: accept prep-pre-flight-checks from .b4-config Clément Le Goffic
2026-07-10 15:51 ` Matthieu Baerts [this message]
2026-07-10 16:04   ` Clément Le Goffic
2026-07-10 16:14     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7e019e7-584f-4be4-bf15-c3ac51be8edc@kernel.org \
    --to=matttbe@kernel.org \
    --cc=clegoffic@baylibre.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.