From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out199-2.us.a.mail.aliyun.com (out199-2.us.a.mail.aliyun.com [47.90.199.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F51A28; Thu, 1 Dec 2022 02:18:44 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R251e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=57;SR=0;TI=SMTPD_---0VW5-8b9_1669857445; Received: from 30.97.48.64(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VW5-8b9_1669857445) by smtp.aliyun-inc.com; Thu, 01 Dec 2022 09:17:29 +0800 Message-ID: Date: Thu, 1 Dec 2022 09:17:30 +0800 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding Cc: Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> From: Baolin Wang In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/30/2022 11:21 PM, Uwe Kleine-König wrote: > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > index 7004f55bbf11..bda8bc5af976 100644 > --- a/drivers/pwm/pwm-sprd.c > +++ b/drivers/pwm/pwm-sprd.c > @@ -65,8 +65,8 @@ static void sprd_pwm_write(struct sprd_pwm_chip *spc, u32 hwid, > writel_relaxed(val, spc->base + offset); > } > > -static void sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > - struct pwm_state *state) > +static int sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > + struct pwm_state *state) > { > struct sprd_pwm_chip *spc = > container_of(chip, struct sprd_pwm_chip, chip); > @@ -83,7 +83,7 @@ static void sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > if (ret) { > dev_err(spc->dev, "failed to enable pwm%u clocks\n", > pwm->hwpwm); > - return; > + return 0; > } > > val = sprd_pwm_read(spc, pwm->hwpwm, SPRD_PWM_ENABLE); > @@ -113,6 +113,8 @@ static void sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > /* Disable PWM clocks if the PWM channel is not in enable state. */ > if (!state->enabled) > clk_bulk_disable_unprepare(SPRD_PWM_CHN_CLKS_NUM, chn->clks); > + > + return 0; > } > > static int sprd_pwm_config(struct sprd_pwm_chip *spc, struct pwm_device *pwm, For sprd pwm parts: Reviewed-by: Baolin Wang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8248AC4321E for ; Thu, 1 Dec 2022 01:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vRuOOVwa3eefqmeFolJ0VgQxeVhKsSjARbGNypV3A/A=; b=alOdo4kc7IRs2D fm2i8m+gnceLEj2j1O+aHNDMt6juh+mVPDrTtmzGtu7rAyzqL+olmQA4zSOwx+H1cx5Rq72gSdnpF XMVEvBtxUkpYm+Dil8JxqGXEXxECWkbp90WOAOSVD5R2JOx1qT5Pf3E/o43j3VEmivRrwDlD0pxh/ fTNHbXUVxgzFEuEaLT1COtLBsHJEW+A4deiFovEfzfnoseMPwi1qM01fLj63UoqJlcCe97gJqop98 1AhLyq0Eh7AUZ8T4PRspFGAIZqddeEaraYBeejg5IzB3k7S3INPzBcp9A9/A4Zcmrm1Vnvy0uE+8/ t7FyHJ7Vjdy9jEByHMdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0YCt-003lLk-FO; Thu, 01 Dec 2022 01:17:43 +0000 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0YCp-003lJf-R1; Thu, 01 Dec 2022 01:17:42 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R251e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=57;SR=0;TI=SMTPD_---0VW5-8b9_1669857445; Received: from 30.97.48.64(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VW5-8b9_1669857445) by smtp.aliyun-inc.com; Thu, 01 Dec 2022 09:17:29 +0800 Message-ID: Date: Thu, 1 Dec 2022 09:17:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding Cc: Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> From: Baolin Wang In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_171740_087966_543CE07A X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org CgpPbiAxMS8zMC8yMDIyIDExOjIxIFBNLCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXNwcmQuYyBiL2RyaXZlcnMvcHdtL3B3bS1zcHJkLmMK PiBpbmRleCA3MDA0ZjU1YmJmMTEuLmJkYThiYzVhZjk3NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L3B3bS9wd20tc3ByZC5jCj4gKysrIGIvZHJpdmVycy9wd20vcHdtLXNwcmQuYwo+IEBAIC02NSw4 ICs2NSw4IEBAIHN0YXRpYyB2b2lkIHNwcmRfcHdtX3dyaXRlKHN0cnVjdCBzcHJkX3B3bV9jaGlw ICpzcGMsIHUzMiBod2lkLAo+ICAgCXdyaXRlbF9yZWxheGVkKHZhbCwgc3BjLT5iYXNlICsgb2Zm c2V0KTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBzcHJkX3B3bV9nZXRfc3RhdGUoc3RydWN0 IHB3bV9jaGlwICpjaGlwLCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdtLAo+IC0JCQkgICAgICAgc3Ry dWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gK3N0YXRpYyBpbnQgc3ByZF9wd21fZ2V0X3N0YXRlKHN0 cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiArCQkJICAgICAg c3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gICB7Cj4gICAJc3RydWN0IHNwcmRfcHdtX2NoaXAg KnNwYyA9Cj4gICAJCWNvbnRhaW5lcl9vZihjaGlwLCBzdHJ1Y3Qgc3ByZF9wd21fY2hpcCwgY2hp cCk7Cj4gQEAgLTgzLDcgKzgzLDcgQEAgc3RhdGljIHZvaWQgc3ByZF9wd21fZ2V0X3N0YXRlKHN0 cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAlpZiAocmV0 KSB7Cj4gICAJCWRldl9lcnIoc3BjLT5kZXYsICJmYWlsZWQgdG8gZW5hYmxlIHB3bSV1IGNsb2Nr c1xuIiwKPiAgIAkJCXB3bS0+aHdwd20pOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gMDsKPiAg IAl9Cj4gICAKPiAgIAl2YWwgPSBzcHJkX3B3bV9yZWFkKHNwYywgcHdtLT5od3B3bSwgU1BSRF9Q V01fRU5BQkxFKTsKPiBAQCAtMTEzLDYgKzExMyw4IEBAIHN0YXRpYyB2b2lkIHNwcmRfcHdtX2dl dF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsIHN0cnVjdCBwd21fZGV2aWNlICpwd20sCj4g ICAJLyogRGlzYWJsZSBQV00gY2xvY2tzIGlmIHRoZSBQV00gY2hhbm5lbCBpcyBub3QgaW4gZW5h YmxlIHN0YXRlLiAqLwo+ICAgCWlmICghc3RhdGUtPmVuYWJsZWQpCj4gICAJCWNsa19idWxrX2Rp c2FibGVfdW5wcmVwYXJlKFNQUkRfUFdNX0NITl9DTEtTX05VTSwgY2huLT5jbGtzKTsKPiArCj4g KwlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGludCBzcHJkX3B3bV9jb25maWcoc3Ry dWN0IHNwcmRfcHdtX2NoaXAgKnNwYywgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKCkZvciBzcHJk IHB3bSBwYXJ0czoKUmV2aWV3ZWQtYnk6IEJhb2xpbiBXYW5nIDxiYW9saW4ud2FuZ0BsaW51eC5h bGliYWJhLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFB04C4321E for ; Thu, 1 Dec 2022 01:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6TsLie6RFUwspAEeResmTaCIA6yXYMeqJm91ShAqC+8=; b=gCiVfIy5bQccBe kVva9Xudgmv9kI+pCKNeNFtf1Fc0rsAhfV+FJQ6oewN2jLpv78cQ1i5/xHKhFyLjBcsH9PoRCqVB3 Vdulr9r559fZk9rmhDVBxnbSRgFW76QE2fhHP+1FqNMj+8ayUirYEb3EMPfvzFOpE8JJMqnazEN0p XIy11B0/CWTnYNMOkh7+EsXUSxUq6lzo12GvJR8fM3rcJaDa/oz1etg5xMTK8R0uAExCHRJFAL5QT lfepZ9pHDNrfo7EgjXSwA0Q6fF9NEtfDkkLmodI90pEHPWsv06AxEm+DmgJLkkTCae2h2kP+pPrzr V5ynycqBpxUmJ7eRG3uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0YCw-003lMa-OC; Thu, 01 Dec 2022 01:17:46 +0000 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0YCp-003lJf-R1; Thu, 01 Dec 2022 01:17:42 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R251e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=57;SR=0;TI=SMTPD_---0VW5-8b9_1669857445; Received: from 30.97.48.64(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VW5-8b9_1669857445) by smtp.aliyun-inc.com; Thu, 01 Dec 2022 09:17:29 +0800 Message-ID: Date: Thu, 1 Dec 2022 09:17:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding Cc: Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> From: Baolin Wang In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_171740_087966_543CE07A X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CgpPbiAxMS8zMC8yMDIyIDExOjIxIFBNLCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXNwcmQuYyBiL2RyaXZlcnMvcHdtL3B3bS1zcHJkLmMK PiBpbmRleCA3MDA0ZjU1YmJmMTEuLmJkYThiYzVhZjk3NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L3B3bS9wd20tc3ByZC5jCj4gKysrIGIvZHJpdmVycy9wd20vcHdtLXNwcmQuYwo+IEBAIC02NSw4 ICs2NSw4IEBAIHN0YXRpYyB2b2lkIHNwcmRfcHdtX3dyaXRlKHN0cnVjdCBzcHJkX3B3bV9jaGlw ICpzcGMsIHUzMiBod2lkLAo+ICAgCXdyaXRlbF9yZWxheGVkKHZhbCwgc3BjLT5iYXNlICsgb2Zm c2V0KTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBzcHJkX3B3bV9nZXRfc3RhdGUoc3RydWN0 IHB3bV9jaGlwICpjaGlwLCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdtLAo+IC0JCQkgICAgICAgc3Ry dWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gK3N0YXRpYyBpbnQgc3ByZF9wd21fZ2V0X3N0YXRlKHN0 cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiArCQkJICAgICAg c3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gICB7Cj4gICAJc3RydWN0IHNwcmRfcHdtX2NoaXAg KnNwYyA9Cj4gICAJCWNvbnRhaW5lcl9vZihjaGlwLCBzdHJ1Y3Qgc3ByZF9wd21fY2hpcCwgY2hp cCk7Cj4gQEAgLTgzLDcgKzgzLDcgQEAgc3RhdGljIHZvaWQgc3ByZF9wd21fZ2V0X3N0YXRlKHN0 cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAlpZiAocmV0 KSB7Cj4gICAJCWRldl9lcnIoc3BjLT5kZXYsICJmYWlsZWQgdG8gZW5hYmxlIHB3bSV1IGNsb2Nr c1xuIiwKPiAgIAkJCXB3bS0+aHdwd20pOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gMDsKPiAg IAl9Cj4gICAKPiAgIAl2YWwgPSBzcHJkX3B3bV9yZWFkKHNwYywgcHdtLT5od3B3bSwgU1BSRF9Q V01fRU5BQkxFKTsKPiBAQCAtMTEzLDYgKzExMyw4IEBAIHN0YXRpYyB2b2lkIHNwcmRfcHdtX2dl dF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsIHN0cnVjdCBwd21fZGV2aWNlICpwd20sCj4g ICAJLyogRGlzYWJsZSBQV00gY2xvY2tzIGlmIHRoZSBQV00gY2hhbm5lbCBpcyBub3QgaW4gZW5h YmxlIHN0YXRlLiAqLwo+ICAgCWlmICghc3RhdGUtPmVuYWJsZWQpCj4gICAJCWNsa19idWxrX2Rp c2FibGVfdW5wcmVwYXJlKFNQUkRfUFdNX0NITl9DTEtTX05VTSwgY2huLT5jbGtzKTsKPiArCj4g KwlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGludCBzcHJkX3B3bV9jb25maWcoc3Ry dWN0IHNwcmRfcHdtX2NoaXAgKnNwYywgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKCkZvciBzcHJk IHB3bSBwYXJ0czoKUmV2aWV3ZWQtYnk6IEJhb2xpbiBXYW5nIDxiYW9saW4ud2FuZ0BsaW51eC5h bGliYWJhLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4254FC4321E for ; Thu, 1 Dec 2022 01:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZLKz8BbwnvMDf03OhNDKbvSBdHYrWOpeTzvBjv+0Yz0=; b=xyZaJo3YOLJDIr IpTfw/w+8ow67bxy7VDb0uLsInsI1Ozo2BBNe/ainWSdeMj4u6SqKtJ8DDFOJkoJjk8m8Ja/gx3mv wy+/7QRB8UVEKrSumicsDTffq+5JElY2mPbdLvck4PrcUTSIoscpp9EqEFWltvTzSTSzMXDIDVsDz 00L+VjS+kdbmgITYVDr1/nCDu6gAULh3m0VhESATwDz0xhTRSK/vlOw/X96lN2wvMS5hZ0uZUQhx+ DA+TS7imGRPGwCNlaU+NjVi0E226ZUDuXqx5MgeK2BAXgQEzCQK9m/nSRygGEX+9qE3whY/MDSIaQ 2wysjf4aK5OuOQAgVhyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0YCv-003lM7-HM; Thu, 01 Dec 2022 01:17:45 +0000 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0YCp-003lJf-R1; Thu, 01 Dec 2022 01:17:42 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R251e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=57;SR=0;TI=SMTPD_---0VW5-8b9_1669857445; Received: from 30.97.48.64(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VW5-8b9_1669857445) by smtp.aliyun-inc.com; Thu, 01 Dec 2022 09:17:29 +0800 Message-ID: Date: Thu, 1 Dec 2022 09:17:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding Cc: Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> From: Baolin Wang In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_171740_087966_543CE07A X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CgpPbiAxMS8zMC8yMDIyIDExOjIxIFBNLCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXNwcmQuYyBiL2RyaXZlcnMvcHdtL3B3bS1zcHJkLmMK PiBpbmRleCA3MDA0ZjU1YmJmMTEuLmJkYThiYzVhZjk3NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L3B3bS9wd20tc3ByZC5jCj4gKysrIGIvZHJpdmVycy9wd20vcHdtLXNwcmQuYwo+IEBAIC02NSw4 ICs2NSw4IEBAIHN0YXRpYyB2b2lkIHNwcmRfcHdtX3dyaXRlKHN0cnVjdCBzcHJkX3B3bV9jaGlw ICpzcGMsIHUzMiBod2lkLAo+ICAgCXdyaXRlbF9yZWxheGVkKHZhbCwgc3BjLT5iYXNlICsgb2Zm c2V0KTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBzcHJkX3B3bV9nZXRfc3RhdGUoc3RydWN0 IHB3bV9jaGlwICpjaGlwLCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdtLAo+IC0JCQkgICAgICAgc3Ry dWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gK3N0YXRpYyBpbnQgc3ByZF9wd21fZ2V0X3N0YXRlKHN0 cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiArCQkJICAgICAg c3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUpCj4gICB7Cj4gICAJc3RydWN0IHNwcmRfcHdtX2NoaXAg KnNwYyA9Cj4gICAJCWNvbnRhaW5lcl9vZihjaGlwLCBzdHJ1Y3Qgc3ByZF9wd21fY2hpcCwgY2hp cCk7Cj4gQEAgLTgzLDcgKzgzLDcgQEAgc3RhdGljIHZvaWQgc3ByZF9wd21fZ2V0X3N0YXRlKHN0 cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAlpZiAocmV0 KSB7Cj4gICAJCWRldl9lcnIoc3BjLT5kZXYsICJmYWlsZWQgdG8gZW5hYmxlIHB3bSV1IGNsb2Nr c1xuIiwKPiAgIAkJCXB3bS0+aHdwd20pOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gMDsKPiAg IAl9Cj4gICAKPiAgIAl2YWwgPSBzcHJkX3B3bV9yZWFkKHNwYywgcHdtLT5od3B3bSwgU1BSRF9Q V01fRU5BQkxFKTsKPiBAQCAtMTEzLDYgKzExMyw4IEBAIHN0YXRpYyB2b2lkIHNwcmRfcHdtX2dl dF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsIHN0cnVjdCBwd21fZGV2aWNlICpwd20sCj4g ICAJLyogRGlzYWJsZSBQV00gY2xvY2tzIGlmIHRoZSBQV00gY2hhbm5lbCBpcyBub3QgaW4gZW5h YmxlIHN0YXRlLiAqLwo+ICAgCWlmICghc3RhdGUtPmVuYWJsZWQpCj4gICAJCWNsa19idWxrX2Rp c2FibGVfdW5wcmVwYXJlKFNQUkRfUFdNX0NITl9DTEtTX05VTSwgY2huLT5jbGtzKTsKPiArCj4g KwlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGludCBzcHJkX3B3bV9jb25maWcoc3Ry dWN0IHNwcmRfcHdtX2NoaXAgKnNwYywgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKCkZvciBzcHJk IHB3bSBwYXJ0czoKUmV2aWV3ZWQtYnk6IEJhb2xpbiBXYW5nIDxiYW9saW4ud2FuZ0BsaW51eC5h bGliYWJhLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlz Y3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7476BC43217 for ; Thu, 1 Dec 2022 08:07:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91B4510E55B; Thu, 1 Dec 2022 08:06:33 +0000 (UTC) X-Greylist: delayed 303 seconds by postgrey-1.36 at gabe; Thu, 01 Dec 2022 01:22:39 UTC Received: from out30-7.freemail.mail.aliyun.com (out30-7.freemail.mail.aliyun.com [115.124.30.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1AB510E00E for ; Thu, 1 Dec 2022 01:22:39 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R251e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018045168; MF=baolin.wang@linux.alibaba.com; NM=1; PH=DS; RN=57; SR=0; TI=SMTPD_---0VW5-8b9_1669857445; Received: from 30.97.48.64(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VW5-8b9_1669857445) by smtp.aliyun-inc.com; Thu, 01 Dec 2022 09:17:29 +0800 Message-ID: Date: Thu, 1 Dec 2022 09:17:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> From: Baolin Wang In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 01 Dec 2022 08:06:25 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Alexandre Torgue , dri-devel@lists.freedesktop.org, Nicolas Ferre , Conor Dooley , Satya Priya , Pavel Machek , Guenter Roeck , Nobuhiro Iwamatsu , linux-riscv@lists.infradead.org, linux-leds@vger.kernel.org, Jerome Brunet , chrome-platform@lists.linux.dev, Florian Fainelli , Samuel Holland , Sean Anderson , Kevin Hilman , Bartosz Golaszewski , Michal Simek , linux-stm32@st-md-mailman.stormreply.com, Hammer Hsieh , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Matthias Kaehlcke , Broadcom internal kernel review list , NXP Linux Team , Orson Zhai , linux-sunxi@lists.linux.dev, linux-pwm@vger.kernel.org, Maxime Coquelin , Martin Blumenstingl , Ray Jui , Sascha Hauer , Stephen Boyd , linux-gpio@vger.kernel.org, Fabrice Gasnier , linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Paul Walmsley , Matthias Brugger , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Scott Branden , Bjorn Andersson , Douglas Anderson , Michael Walle , Palmer Dabbelt , Pengutronix Kernel Team , Chunyan Zhang , Shawn Guo , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/30/2022 11:21 PM, Uwe Kleine-König wrote: > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > index 7004f55bbf11..bda8bc5af976 100644 > --- a/drivers/pwm/pwm-sprd.c > +++ b/drivers/pwm/pwm-sprd.c > @@ -65,8 +65,8 @@ static void sprd_pwm_write(struct sprd_pwm_chip *spc, u32 hwid, > writel_relaxed(val, spc->base + offset); > } > > -static void sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > - struct pwm_state *state) > +static int sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > + struct pwm_state *state) > { > struct sprd_pwm_chip *spc = > container_of(chip, struct sprd_pwm_chip, chip); > @@ -83,7 +83,7 @@ static void sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > if (ret) { > dev_err(spc->dev, "failed to enable pwm%u clocks\n", > pwm->hwpwm); > - return; > + return 0; > } > > val = sprd_pwm_read(spc, pwm->hwpwm, SPRD_PWM_ENABLE); > @@ -113,6 +113,8 @@ static void sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > /* Disable PWM clocks if the PWM channel is not in enable state. */ > if (!state->enabled) > clk_bulk_disable_unprepare(SPRD_PWM_CHN_CLKS_NUM, chn->clks); > + > + return 0; > } > > static int sprd_pwm_config(struct sprd_pwm_chip *spc, struct pwm_device *pwm, For sprd pwm parts: Reviewed-by: Baolin Wang