From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0753B24E4A1 for ; Wed, 17 Jun 2026 05:58:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781675885; cv=none; b=SvbL0ERgzEONPCyTUN7GhrOrB8KT1xrmEv8fD1avx+R+2eVjv85UyFvOam/4MDL9i5IfmR3bB0hHt7vgpUQ9yrPx1Kxgn2A7zj/k5fnzl3CvhvCsDka+HFHDa+v+rc1/llwGCm6cLzquLjsh6nDEpShzthz4E3PFcRUfNWHKQuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781675885; c=relaxed/simple; bh=ifP1Jm9pQSvr4BBArcOmxENG+EW9+nj1rdJ9cv+TplY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s7eM73yeK2rELBNKjGWAU2cANy4DVcZizZtS8OFpZfVGYdDI15RzTO6yf0Qb5xu61oaLHYdvWlrI7rD71t54jlknY/Y5GB0EoUGeGnWawnjyh79U3/yftmxgR6pN0I9r6Ncfy33SzXgQP5KSrs2jYH32AdSsbbDTlcM45kOkZF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CehtRShK; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CehtRShK" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5aa7a7ad475so5890162e87.1 for ; Tue, 16 Jun 2026 22:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781675882; x=1782280682; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lVtSo+MU4Z53OtbGrnPGc6UwBuGxvobCSSEYgeFvA3c=; b=CehtRShK2t1SxqRDb131sNl0Uu2ULwdKTO3KRBErhU7LcHaSMQcVan4XsU8Abt6ACI iD8Pzn1RJHwLa3jflFdg9oeHbirC7FP7jkEP3Pi0QPHbOBbKJg2NFCrHiYal+5qLx+08 i2RqGKTbTJdUxjPZqGEANV7PDD3YCCjq4HKrKsPeWTPHXxOAaYv+ttBUx+6uyeULroem InoNfMJdgNUcI5jbfDG82tptFfb79jXcLrykfyo4pG2lR67kCApKeGjvihok+rIVSfbd HrV2RlgZPzNw6EEl7joeX19ZEpyj4KjEUB3zr8lTzd58JKYJCOdbIqYUwxjiUWJNU0L/ kIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781675882; x=1782280682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lVtSo+MU4Z53OtbGrnPGc6UwBuGxvobCSSEYgeFvA3c=; b=bCvvyY2lWKcwiI1sPndxJH4E8bCxsMTns/ijIZh5ni7eom9qHeThPXlhnW7oYIENAX 9MsZ1RpRZsToSlgokMR/71XFrOhyiitRa60kNyckS2SDpFoHegw7reTqSnn0xIS2QVHk PcnhupbRWmQzquHeyueuEvBD6dQS+ESJf7x7Jcm//IYvTOmhIxBd2LZkrPiIN6UwdNkJ tgc224pJSkS/hXzK2Ab8nYLhn0uH/1XhgkxUWyHmvfPRa0EdrRgOhVPC5OQKa5xJddie BTQVKCVFYf/g03e71NM3jRbJASMHQJ6M6TNy355/ILaYf6WHEnTOKmFL2ngrGfkY98ja 5wzQ== X-Forwarded-Encrypted: i=1; AFNElJ+yV/lLiXwUuHVL6SkdE+BQBiUCUPTylIgiM0n3nZyD1+tiWes04L+7D2QfE4JE/zwVngqKB13ri6HHP+g=@vger.kernel.org X-Gm-Message-State: AOJu0YxyWFUV357FOs9ammp2c6dDvxYNOdq5AwBBYPCA4HRVQocOtOxH 3CbrdakEmsbSLY8bc7AvD6clLXPQo9FTx5+sSmuRbOBzzQ0GUhYIoR0F X-Gm-Gg: Acq92OGNFQWI7gZjjJJMXUvc+r1jT5uZ4nbgHDmt2ogSsPXydKscgCKHDfEeOGvv3Xq JNWJoAZVAafK/bMypefPoOJ7R6l1ul+ae1Emxch6Be38hnZeVxn9rAgxRzAu1lYXuZqh0IcBuDg m0MMhotwqUEzSHhSB1dTbYhpWUp4n8DUQCRK5roC25bN9wcqQ3bejmzqKIWkDE/WiIpfQ9qnzvO sax7mjAnYTymiRDt6ynSyQG/lTagQxTcIDHlrkOKxDVpeQpZiVvBFBW8M8j5JTi63rSU46F97er acL2MA7ZprMKJRd/u8bsNFOOaleVXOmj0hvfvYN9mrRa7rVTdylYE1e02lO+1ls1VFFeqK0/527 QpQt1zTHl4t93nmOFHuA4anlo18oHFloIVXV1MchqO9y2XrBuwO0+0D3HuMX+y4tq8j+PZwBo7W aMqf6MF8fS798bqLU1HyVhHaTFOcsjPFVK6xyh3nT83V/UU6lxOOCxhPIFBI9Wpr9xhCWxKQ== X-Received: by 2002:ac2:547b:0:b0:5aa:517b:65bb with SMTP id 2adb3069b0e04-5ad47ffe467mr313621e87.37.1781675882037; Tue, 16 Jun 2026 22:58:02 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3995c19ad3asm12697871fa.31.2026.06.16.22.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 22:58:00 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 08:57:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] hwmon: adm1275: Support ROHM BD12790 To: Guenter Roeck , Matti Vaittinen , Matti Vaittinen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Wensheng Wang , Ashish Yadav , Kim Seer Paller , Cedric Encarnacion , Chris Packham , Yuxi Wang , Charles Hsu , ChiShih Tsai , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <8ca875d21f2d9a4d53a87b47a5e6efab48266178.1781591132.git.mazziesaccount@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/06/2026 17:15, Guenter Roeck wrote: > On 6/15/26 23:44, Matti Vaittinen wrote: >> From: Matti Vaittinen >> >> Add support for ROHM BD12790 hot-swap controller which is largely >> similar to Analog Devices adm1272. >> >> The BD12790 uses the same selectable 60V/100V voltage ranges and >> 15mV/30mV current-sense ranges as the ADM1272, and the same VRANGE >> (bit 5) and IRANGE (bit 0) layout in PMON_CONFIG. It therefore uses >> a dedicated coefficient table that mirrors adm1272_coefficients, with >> the following differences derived from BD12790 datasheet Table 1 (p.18): >> - power 60V/30mV: m=17560 (vs. 17561) >> - power 100V/30mV: m=10536 (vs. 10535) >> - temperature: b=31880 (vs. 31871, reflecting T[11:0] = 4.2*T + 3188) >> >> Signed-off-by: Matti Vaittinen >> Assisted-by: GitHub Copilot:claude-sonnet-4.6 >> >> --- // snip >> -/* The BD12780 data sheets mark TSFILT bit as reserved. */ >> -#define BD12780_PMON_DEFCONFIG        (ADM1278_VOUT_EN | >> ADM1278_TEMP1_EN) >> +/* The BD127x0 data sheets mark TSFILT bit as reserved. */ >> +#define BD127X0_PMON_DEFCONFIG        (ADM1278_VOUT_EN | >> ADM1278_TEMP1_EN) > > Please don't use such placeholders. Just use BD12780_PMON_DEFCONFIG > for both chips, similar to how the defines for all other chips > are handled. Ok, thanks. Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~