From: Jan Beulich <jbeulich@suse.com>
To: Federico Serafini <federico.serafini@bugseng.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: consulting@bugseng.com, Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH 2/3] xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3
Date: Tue, 25 Jul 2023 09:09:28 +0200 [thread overview]
Message-ID: <a81326f4-e018-b461-ebec-9ef2ff5dc4df@suse.com> (raw)
In-Reply-To: <a62e88a9c29cf7866c251968b5a5b6865aff4a2a.1690217195.git.federico.serafini@bugseng.com>
On 24.07.2023 19:50, Federico Serafini wrote:
> @@ -182,7 +182,8 @@ void irq_set_affinity(struct irq_desc *desc, const cpumask_t *cpu_mask)
> }
>
> int request_irq(unsigned int irq, unsigned int irqflags,
> - void (*handler)(int, void *, struct cpu_user_regs *),
> + void (*handler)(int irq, void *dev_id,
> + struct cpu_user_regs *regs),
> const char *devname, void *dev_id)
> {
Before we accept patches, don't we need to first settle on whether to
apply the rule(s) also to function type declarations (and not just
ordinary prototypes)?
Jan
next prev parent reply other threads:[~2023-07-25 7:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 17:50 [XEN PATCH 0/3] IRQ: address violations of MISRA C:2012 Rules 8.2 and 8.3 Federico Serafini
2023-07-24 17:50 ` [XEN PATCH 1/3] xen/irq: add missing parameter names Federico Serafini
2023-07-24 22:50 ` Stefano Stabellini
2023-07-24 17:50 ` [XEN PATCH 2/3] xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3 Federico Serafini
2023-07-24 18:05 ` Julien Grall
2023-07-24 22:55 ` Stefano Stabellini
2023-07-25 19:35 ` Federico Serafini
2023-07-25 7:09 ` Jan Beulich [this message]
2023-07-25 19:32 ` Stefano Stabellini
2023-07-27 11:02 ` Federico Serafini
2023-07-27 11:27 ` Jan Beulich
2023-07-27 13:20 ` Federico Serafini
2023-07-27 19:39 ` Stefano Stabellini
2023-07-24 17:50 ` [XEN PATCH 3/3] x86/irq: address violations of MISRA C:2012 " Federico Serafini
2023-07-24 23:08 ` Stefano Stabellini
2023-07-25 7:13 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81326f4-e018-b461-ebec-9ef2ff5dc4df@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=consulting@bugseng.com \
--cc=federico.serafini@bugseng.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.