All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aravind Thokala <aravind.thokala@amd.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
	Tom Rix <trix@redhat.com>, Michal Simek <michal.simek@amd.com>,
	linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: add shutdown() handler
Date: Thu, 19 Nov 2026 10:35:28 +0530	[thread overview]
Message-ID: <a813c219-ca5a-4c53-bb44-265402faaa2f@amd.com> (raw)
In-Reply-To: <avhbivs3HDdvzrtB@yilunxu-OptiPlex-7050>

Hi Xu Yilun,

On 11/14/2026 6:30 PM, Xu Yilun wrote:
> On Tue, Nov 10, 2026 at 12:46:35PM +0530, Aravind Thokala wrote:
>> Add a .shutdown() handler to decouple the Reconfigurable Partition
>> from the static logic on reboot, shutdown, and kexec.
> 
> I'm not sure what problem are you going to solve by gating the PR region
> from static region regardless. Please specify.
> 
> Before I get enough information, I generally think that's not the right
> way to solve problems. You need to gracefully handle the specific logic
> inside the PR region which actually impact kexec, so that they work in
> expected ways, rather than abruptly cutting down the HW connection
> regardless.
> 

Thank you for the review. I will look into this further and follow up 
with more details.

Best regards,
Aravind.

>>
>> The handler writes CTRL_CMD_DECOUPLE to the control register. On the
>> PR Decoupler, this turns decoupling on, which stops signal changes
>> passing through the bridge. On the DFX AXI Shutdown Manager, it
>> requests that the IP stop passing AXI transactions through.
>>
>> Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
>> ---
>>   drivers/fpga/xilinx-pr-decoupler.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index 1405ddbe88f1..75b59edbf440 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -137,6 +137,13 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
>>   	return 0;
>>   }
>>   
>> +static void xlnx_pr_decoupler_shutdown(struct platform_device *pdev)
>> +{
>> +	struct fpga_bridge *bridge = platform_get_drvdata(pdev);
>> +
>> +	xlnx_pr_decoupler_enable_set(bridge, false);
>> +}
>> +
>>   static void xlnx_pr_decoupler_remove(struct platform_device *pdev)
>>   {
>>   	struct fpga_bridge *bridge = platform_get_drvdata(pdev);
>> @@ -147,6 +154,7 @@ static void xlnx_pr_decoupler_remove(struct platform_device *pdev)
>>   static struct platform_driver xlnx_pr_decoupler_driver = {
>>   	.probe = xlnx_pr_decoupler_probe,
>>   	.remove = xlnx_pr_decoupler_remove,
>> +	.shutdown = xlnx_pr_decoupler_shutdown,
>>   	.driver = {
>>   		.name = "xlnx_pr_decoupler",
>>   		.of_match_table = xlnx_pr_decoupler_of_match,
>>
>> ---
>> base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
>> change-id: 20261110-pr_decoupler_shutdown_handler-bf2596f6d1de
>>
>> Best regards,
>> --
>> Aravind Thokala <aravind.thokala@amd.com>
>>
>>


      reply	other threads:[~2026-11-19  5:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  7:16 [PATCH] fpga: xilinx-pr-decoupler: add shutdown() handler Aravind Thokala
2026-11-14 13:00 ` Xu Yilun
2026-11-19  5:05   ` Aravind Thokala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a813c219-ca5a-4c53-bb44-265402faaa2f@amd.com \
    --to=aravind.thokala@amd.com \
    --cc=git@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    --cc=yilun.xu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.