All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Avri Altman <avri.altman@wdc.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ming Lei <ming.lei@redhat.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Kiwoong Kim <kwmad.kim@samsung.com>
Subject: Re: [PATCH v3 8/9] scsi: core: Set BLK_SUB_PAGE_SEGMENTS for small max_segment_size values
Date: Thu, 19 Jan 2023 09:27:29 -0800	[thread overview]
Message-ID: <a849cb56-a384-530d-e12e-1dba2bed4355@acm.org> (raw)
In-Reply-To: <20230119053852.GA16933@lst.de>

On 1/18/23 21:38, Christoph Hellwig wrote:
>> +	if (shost->max_segment_size && shost->max_segment_size < PAGE_SIZE)
>> +		blk_queue_flag_set(QUEUE_FLAG_SUB_PAGE_SEGMENTS, q);
> 
> Independ of me really not wanting this code at all if we can avoid it:
> this has no business in the SCSI midlayer or drivers.  Once the config
> option is enabled, setting the flag should happen inside
> blk_queue_max_segment_size.

Hi Christoph,

Thanks for having taken a look. I will move this code into the block layer.

Thanks,

Bart.

  reply	other threads:[~2023-01-19 17:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 22:54 [PATCH v3 0/9] Add support for segments smaller than one page Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 1/9] block: Introduce QUEUE_FLAG_SUB_PAGE_SEGMENTS and CONFIG_BLK_SUB_PAGE_SEGMENTS Bart Van Assche
2023-01-18 23:02   ` Jens Axboe
2023-01-18 23:40     ` Bart Van Assche
2023-01-21  0:11     ` Bart Van Assche
2023-01-21  2:43       ` Jens Axboe
2023-01-23 19:58         ` Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 2/9] block: Support configuring limits below the page size Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 3/9] block: Support submitting passthrough requests with small segments Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 4/9] block: Add support for filesystem requests and " Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 5/9] block: Add support for small segments in blk_rq_map_user_iov() Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 6/9] scsi_debug: Support configuring the maximum segment size Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 7/9] null_blk: " Bart Van Assche
2023-01-18 22:54 ` [PATCH v3 8/9] scsi: core: Set BLK_SUB_PAGE_SEGMENTS for small max_segment_size values Bart Van Assche
2023-01-19  5:38   ` Christoph Hellwig
2023-01-19 17:27     ` Bart Van Assche [this message]
2023-01-18 22:54 ` [PATCH v3 9/9] scsi: ufs: exynos: Select CONFIG_BLK_SUB_PAGE_SEGMENTS for lage page sizes Bart Van Assche
2023-01-28  3:55   ` Ming Lei
2023-01-29  1:09     ` Bart Van Assche
2023-01-19  1:18 ` [PATCH v3 0/9] Add support for segments smaller than one page Jens Axboe
2023-01-19  4:43   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a849cb56-a384-530d-e12e-1dba2bed4355@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.