All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mukesh Ojha <mojha@codeaurora.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Query on skip_onerr field in struct cpuhp_step
Date: Tue, 21 Aug 2018 20:10:47 +0530	[thread overview]
Message-ID: <a8599754-5c8b-1667-1685-901f53319064@codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1808211557180.1535@nanos.tec.linutronix.de>



On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
> On Tue, 21 Aug 2018, Mukesh Ojha wrote:
>> Hi All,
>>
>> This is about one of field in struct cpuhp_step
>>
>> * @skip_onerr: Do not invoke the functions on error rollback
>>   *              Will go away once the notifiers are gone
>>          bool                    skip_onerr;
>>
>> Why this field was introduced, can anyone explain the history behind ? As i
>> don't see it being set from anywhere
>>
>> If it is specifically was dependent on notifiers, did we missed to remove it
>> as the notifiers are gone or the usecase still there?
> As the comment says....

Thanks for your reply
Sorry, for further question but i did not get the comment ..did you 
mean, we can remove this from the structure as notifier are
not their now. ?

Also if you are aware with the history, can you tell , why would i want 
to avoid a call in undo_cpu_up path?

Thanks,
Mukesh



  reply	other threads:[~2018-08-21 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 13:47 Query on skip_onerr field in struct cpuhp_step Mukesh Ojha
2018-08-21 13:57 ` Thomas Gleixner
2018-08-21 14:40   ` Mukesh Ojha [this message]
2018-08-25 18:27     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8599754-5c8b-1667-1685-901f53319064@codeaurora.org \
    --to=mojha@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.