From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Anastasov Subject: Re: [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4 Date: Mon, 17 Apr 2023 19:59:35 +0300 (EEST) Message-ID: References: <20230409-ipvs-cleanup-v3-0-5149ea34b0b9@kernel.org> Mime-Version: 1.0 Return-path: In-Reply-To: <20230409-ipvs-cleanup-v3-0-5149ea34b0b9@kernel.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Horatiu Vultur Hello, On Mon, 17 Apr 2023, Simon Horman wrote: > Hi Julian, > > this series aims to clean up IPVS in several ways without > implementing any functional changes, aside from removing > some debugging output. > > Patch 1/4: Update width of source for ip_vs_sync_conn_options > The operation is safe, use an annotation to describe it properly. > > Patch 2/4: Consistently use array_size() in ip_vs_conn_init() > It seems better to use helpers consistently. > > Patch 3/4: Remove {Enter,Leave}Function > These seem to be well past their use-by date. > > Patch 4/4: Correct spelling in comments > I can't spell. But codespell helps me these days. > > All changes: compile tested only! > > --- > Changes in v3: > - Patch 2/4: Correct division by 1024. > It was applied to the wrong variable in v2. > - Add Horatiu's Reviewed-by tag. > > Changes in v2: > - Patch 1/4: Correct spelling of 'conn' in subject. > - Patch 2/4: Restore division by 1024. It was lost on v1. > > --- > Simon Horman (4): > ipvs: Update width of source for ip_vs_sync_conn_options > ipvs: Consistently use array_size() in ip_vs_conn_init() > ipvs: Remove {Enter,Leave}Function > ipvs: Correct spelling in comments The patchset looks good to me, thanks! Acked-by: Julian Anastasov > include/net/ip_vs.h | 32 +++++---------------- > net/netfilter/ipvs/ip_vs_conn.c | 12 ++++---- > net/netfilter/ipvs/ip_vs_core.c | 8 ------ > net/netfilter/ipvs/ip_vs_ctl.c | 26 +---------------- > net/netfilter/ipvs/ip_vs_sync.c | 7 +---- > net/netfilter/ipvs/ip_vs_xmit.c | 62 ++++++----------------------------------- > 6 files changed, 23 insertions(+), 124 deletions(-) > > base-commit: 99676a5766412f3936c55b9d18565d248e5463ee Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C45EEC77B7A for ; Mon, 17 Apr 2023 16:59:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjDQQ7r (ORCPT ); Mon, 17 Apr 2023 12:59:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjDQQ7q (ORCPT ); Mon, 17 Apr 2023 12:59:46 -0400 Received: from mg.ssi.bg (mg.ssi.bg [193.238.174.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D2AEB4; Mon, 17 Apr 2023 09:59:45 -0700 (PDT) Received: from mg.ssi.bg (localhost [127.0.0.1]) by mg.bb.i.ssi.bg (Proxmox) with ESMTP id CEC681B28D; Mon, 17 Apr 2023 19:59:41 +0300 (EEST) Received: from ink.ssi.bg (ink.ssi.bg [193.238.174.40]) by mg.bb.i.ssi.bg (Proxmox) with ESMTPS id B557B1B257; Mon, 17 Apr 2023 19:59:41 +0300 (EEST) Received: from ja.ssi.bg (unknown [178.16.129.10]) by ink.ssi.bg (Postfix) with ESMTPS id A51913C043A; Mon, 17 Apr 2023 19:59:36 +0300 (EEST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.17.1/8.16.1) with ESMTP id 33HGxZgk120021; Mon, 17 Apr 2023 19:59:35 +0300 Date: Mon, 17 Apr 2023 19:59:35 +0300 (EEST) From: Julian Anastasov To: Simon Horman cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Horatiu Vultur Subject: Re: [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4 In-Reply-To: <20230409-ipvs-cleanup-v3-0-5149ea34b0b9@kernel.org> Message-ID: References: <20230409-ipvs-cleanup-v3-0-5149ea34b0b9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hello, On Mon, 17 Apr 2023, Simon Horman wrote: > Hi Julian, > > this series aims to clean up IPVS in several ways without > implementing any functional changes, aside from removing > some debugging output. > > Patch 1/4: Update width of source for ip_vs_sync_conn_options > The operation is safe, use an annotation to describe it properly. > > Patch 2/4: Consistently use array_size() in ip_vs_conn_init() > It seems better to use helpers consistently. > > Patch 3/4: Remove {Enter,Leave}Function > These seem to be well past their use-by date. > > Patch 4/4: Correct spelling in comments > I can't spell. But codespell helps me these days. > > All changes: compile tested only! > > --- > Changes in v3: > - Patch 2/4: Correct division by 1024. > It was applied to the wrong variable in v2. > - Add Horatiu's Reviewed-by tag. > > Changes in v2: > - Patch 1/4: Correct spelling of 'conn' in subject. > - Patch 2/4: Restore division by 1024. It was lost on v1. > > --- > Simon Horman (4): > ipvs: Update width of source for ip_vs_sync_conn_options > ipvs: Consistently use array_size() in ip_vs_conn_init() > ipvs: Remove {Enter,Leave}Function > ipvs: Correct spelling in comments The patchset looks good to me, thanks! Acked-by: Julian Anastasov > include/net/ip_vs.h | 32 +++++---------------- > net/netfilter/ipvs/ip_vs_conn.c | 12 ++++---- > net/netfilter/ipvs/ip_vs_core.c | 8 ------ > net/netfilter/ipvs/ip_vs_ctl.c | 26 +---------------- > net/netfilter/ipvs/ip_vs_sync.c | 7 +---- > net/netfilter/ipvs/ip_vs_xmit.c | 62 ++++++----------------------------------- > 6 files changed, 23 insertions(+), 124 deletions(-) > > base-commit: 99676a5766412f3936c55b9d18565d248e5463ee Regards -- Julian Anastasov