From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38485C433EF for ; Sun, 22 May 2022 13:59:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0BCBD83EB4; Sun, 22 May 2022 15:59:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Wlbp0v0c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A2EC83F27; Sun, 22 May 2022 15:59:09 +0200 (CEST) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25F2583EF9 for ; Sun, 22 May 2022 15:58:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x631.google.com with SMTP id gh17so10720003ejc.6 for ; Sun, 22 May 2022 06:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=CYdFGp3AnuynaJAbsUuYRLbZ1vIi8Ey1fQrh5qdNzIM=; b=Wlbp0v0cdFCLj6SakNEuXTnqjQtVD3a3yXZgy06W1wiSH6U4aHrLA7MXowW2JM81gP lePEp19Qd03Ye4D+LvC2256vpBrCFQyb/t37jnWR0Am16OI0pwIcXQRlgI2TlhLqUgcl icKFz9+Gc5irAG+2FBhioDsCRQrYEZR+ZvejIYK9GkDsHY7WBDEWJLwtHZtdQHqG25Sl d+RTwmEF11t4RcHgOw+GEAb4LSlfUIBbPe8ckYjPupv8FKaFId/FDiJvds5Tfz2aOOJJ SjtfvIAk9+plq9L1dNUk6iYSfG1Tp+I+XbZ0PpLQmydkev/R5pblYmP0UPMZBS5yPx0D GmMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=CYdFGp3AnuynaJAbsUuYRLbZ1vIi8Ey1fQrh5qdNzIM=; b=qetwr/5eCHp3yiXbELdaK6C2Vb7sx4MBdHcpKsBGyKkuj9yQ1/dwYZWYtPiS2SJT43 N1wCI1XezRpSs1+s4p/58SYuukZqjkJMtLoL7fs8vt+ak8VCdTHisTwJAI7K4Poir765 v5PE6ZXoCQLvt2RkQxt2L0O79xPqBUZHUCUvUMDzbLY7UtKuUvnlAk2pY8Mybq2FlnQn S+EpwvmlnDqppaCoAd3EVB8M6YrCBTUaH/dbttCE7wDvYbGT6uk2KmzjoER+ukjA9CWZ dXEYhin7hHCrkwpBP5aVp0KmqwuT2ov6SVIXCtuv32GL5HeILsyGYs4wGGor4/Dex4SA MS8g== X-Gm-Message-State: AOAM530vkrLRPQbASBv7Ef7XbEFb/h0TfqYXxTcV8FzJxn58PfudpILd YZjeRyxDhoLd1u8Z0+buR2I= X-Google-Smtp-Source: ABdhPJwR9GRThj4w2pRsAwnrU48RszTgBMpWOnlKRjPL2uor9XefxyVu+JbPa723LtKXZq3tJFClVw== X-Received: by 2002:a17:907:6e11:b0:6fe:7e13:345c with SMTP id sd17-20020a1709076e1100b006fe7e13345cmr15618693ejc.588.1653227938326; Sun, 22 May 2022 06:58:58 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id p15-20020a05640210cf00b0042aaa3b741esm6974607edu.1.2022.05.22.06.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 06:58:57 -0700 (PDT) Message-ID: Date: Sun, 22 May 2022 16:56:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Alper Nebi Yasak Subject: Re: [PATCH V4 2/8] arm: dts: imx8m: update binman ddr firmware node name To: "Peng Fan (OSS)" Cc: u-boot@lists.denx.de, Peng Fan , sbabic@denx.de, festevam@gmail.com, ariel.dalessandro@collabora.com, michael@amarulasolutions.com, tharvey@gateworks.com, sjg@chromium.org, marek.behun@nic.cz, pali@kernel.org, sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com, trini@konsulko.com, "NXP i.MX U-Boot Team" References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-3-peng.fan@oss.nxp.com> Content-Language: en-US In-Reply-To: <20220520141048.20034-3-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 20/05/2022 17:10, Peng Fan (OSS) wrote: > From: Peng Fan > > We are migrating to use BINMAN SYMBOLS, the current name is not > a valid binman type, so update to use blob-ext@[1,2,3,4]. > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mm-u-boot.dtsi | 8 ++++---- > arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 4 ++-- > arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi | 8 ++++---- > arch/arm/dts/imx8mn-venice-u-boot.dtsi | 8 ++++---- > arch/arm/dts/imx8mq-u-boot.dtsi | 8 ++++---- > 5 files changed, 18 insertions(+), 18 deletions(-) I think descriptive entry names are better in general, so I prefer the old names to a bunch of 'blob-ext's. Symbol resolution is done using the entry names anyway, I don't see why this change would be necessary. In any case, the names and labels should be consistent across the different dts files, assuming the blobs have the same purpose / meaning. I see that labels starting with digits cause a dtc parse error, so the entries could be `imem_1d: imem-1d { ... };` and so on. Also, the blobs essentially look the same to me aside from their filenames, just duplicated over different imx8m* variants and boards. Maybe binman parts could be unified into a single dtsi file later on? (Filename differences can be handled by new 'blob_named_by_arg's btw.) > diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u-boot.dtsi > index 9f66cdb65a9..5de55a2d80b 100644 > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > @@ -39,25 +39,25 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + imem_1d: blob-ext@1 { > filename = "lpddr4_pmu_train_1d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 1d-dmem { > + dmem_1d: blob-ext@2 { > filename = "lpddr4_pmu_train_1d_dmem.bin"; > size = <0x4000>; > type = "blob-ext"; > }; > > - 2d-imem { > + imem_2d: blob-ext@3 { > filename = "lpddr4_pmu_train_2d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 2d-dmem { > + dmem_2d: blob-ext@4 { > filename = "lpddr4_pmu_train_2d_dmem.bin"; > size = <0x4000>; > type = "blob-ext"; > diff --git a/arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi b/arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi > index 46a9d7fd78b..5a52b73d7e9 100644 > --- a/arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi > +++ b/arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi > @@ -111,13 +111,13 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + imem_1d: blob-ext@1 { > filename = "ddr3_imem_1d.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 1d_dmem { > + dmem_1d: blob-ext@2 { > filename = "ddr3_dmem_1d.bin"; > size = <0x4000>; > type = "blob-ext"; > diff --git a/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi b/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi > index 6e37622cca7..001e725f568 100644 > --- a/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi > +++ b/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi > @@ -130,25 +130,25 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + blob_1: blob-ext@1 { > filename = "ddr4_imem_1d.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 1d_dmem { > + blob_2: blob-ext@2 { > filename = "ddr4_dmem_1d.bin"; > size = <0x4000>; > type = "blob-ext"; > }; > > - 2d_imem { > + blob_3: blob-ext@3 { > filename = "ddr4_imem_2d.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 2d_dmem { > + blob_4: blob-ext@4 { > filename = "ddr4_dmem_2d.bin"; > size = <0x4000>; > type = "blob-ext"; > diff --git a/arch/arm/dts/imx8mn-venice-u-boot.dtsi b/arch/arm/dts/imx8mn-venice-u-boot.dtsi > index 35819553879..67922146963 100644 > --- a/arch/arm/dts/imx8mn-venice-u-boot.dtsi > +++ b/arch/arm/dts/imx8mn-venice-u-boot.dtsi > @@ -126,25 +126,25 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + imem_1d: blob-ext@1 { > filename = "lpddr4_pmu_train_1d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 1d_dmem { > + dmem_1d: blob-ext@2 { > filename = "lpddr4_pmu_train_1d_dmem.bin"; > size = <0x4000>; > type = "blob-ext"; > }; > > - 2d_imem { > + imem_2d: blob-ext@3 { > filename = "lpddr4_pmu_train_2d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 2d_dmem { > + dmem_2d: blob-ext@4 { > filename = "lpddr4_pmu_train_2d_dmem.bin"; > size = <0x4000>; > type = "blob-ext"; > diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi > index 912a3d4a356..389414ad26f 100644 > --- a/arch/arm/dts/imx8mq-u-boot.dtsi > +++ b/arch/arm/dts/imx8mq-u-boot.dtsi > @@ -46,25 +46,25 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + imem_1d: blob-ext@1 { > filename = "lpddr4_pmu_train_1d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 1d-dmem { > + dmem_1d: blob-ext@2 { > filename = "lpddr4_pmu_train_1d_dmem.bin"; > size = <0x4000>; > type = "blob-ext"; > }; > > - 2d-imem { > + imem_2d: blob-ext@3 { > filename = "lpddr4_pmu_train_2d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > - 2d-dmem { > + dmem_2d: blob-ext@4 { > filename = "lpddr4_pmu_train_2d_dmem.bin"; > size = <0x4000>; > type = "blob-ext";