From: Yongpeng Yang <yangyongpeng.storage@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Jan Kara <jack@suse.cz>, Carlos Maiolino <cem@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, stable@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Yongpeng Yang <yangyongpeng@xiaomi.com>
Subject: Re: [PATCH v3] fix missing sb_min_blocksize() return value checks in some filesystems
Date: Tue, 4 Nov 2025 00:22:20 +0800 [thread overview]
Message-ID: <a89cb9af-784d-41a6-9f1e-dfa28d09be29@gmail.com> (raw)
In-Reply-To: <aQi4Q536D6VviQ-6@infradead.org>
On 11/3/2025 10:12 PM, Christoph Hellwig wrote:
> On Mon, Nov 03, 2025 at 09:50:24PM +0800, Yongpeng Yang wrote:
>> From: Yongpeng Yang <yangyongpeng@xiaomi.com>
>>
>> When emulating an nvme device on qemu with both logical_block_size and
>> physical_block_size set to 8 KiB, but without format, a kernel panic
>> was triggered during the early boot stage while attempting to mount a
>> vfat filesystem.
>
> Please split this into a patch per file system, with a proper commit
> log for each.
>
>> Cc: <stable@vger.kernel.org> # v6.15
>> Fixes: a64e5a596067bd ("bdev: add back PAGE_SIZE block size validation
>> for sb_set_blocksize()")
>
> That just adds back one error case in sb_set_blocksize.
>
> The Fixes tag should be for the commit adding the call to
> sb_set_blocksize / sb_min_blocksize in each of the file systems.
>
Thanks for the suggestion. I'll send v3 and split the changes into
multiple patches.
Yongpeng,
prev parent reply other threads:[~2025-11-03 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 13:50 [PATCH v3] fix missing sb_min_blocksize() return value checks in some filesystems Yongpeng Yang
2025-11-03 14:12 ` Christoph Hellwig
2025-11-03 16:22 ` Yongpeng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89cb9af-784d-41a6-9f1e-dfa28d09be29@gmail.com \
--to=yangyongpeng.storage@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yangyongpeng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.