From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Weinehall <david.weinehall@linux.intel.com>,
"Tangudu, Tilak" <tilak.tangudu@intel.com>
Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915/runtime_pm: Reduce autosuspend delay to 1s.
Date: Fri, 27 Aug 2021 10:54:35 +0000 [thread overview]
Message-ID: <a8a18298e46c43a49da7369fba92ca99@intel.com> (raw)
In-Reply-To: <20210825152233.2151037-4-rodrigo.vivi@intel.com>
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Rodrigo
> Vivi
> Sent: Wednesday, August 25, 2021 8:53 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Daniel Vetter
> <daniel.vetter@ffwll.ch>; David Weinehall <david.weinehall@linux.intel.com>;
> Tangudu, Tilak <tilak.tangudu@intel.com>
> Subject: [Intel-gfx] [PATCH 4/4] drm/i915/runtime_pm: Reduce autosuspend
> delay to 1s.
>
> Let's try to be more aggressive on the power savings, but not as much as 0.1s
> that caused us some regression in the past.
In IGT we are already using 0 second as auto suspend delay.
Looks good to me.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
>
> Also let's have this in a separated patch so that can be bisected and increased
> back (or reverted) as needed.
>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Tilak Tangudu <tilak.tangudu@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 8f052bd4f58c..3244ac85d13c 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -585,7 +585,7 @@ void intel_runtime_pm_enable(struct intel_runtime_pm
> *rpm)
> */
> dev_pm_set_driver_flags(kdev, DPM_FLAG_NO_DIRECT_COMPLETE);
>
> - pm_runtime_set_autosuspend_delay(kdev, 10000); /* 10s */
> + pm_runtime_set_autosuspend_delay(kdev, 1000); /* 1s */
> pm_runtime_mark_last_busy(kdev);
>
> /*
> --
> 2.31.1
next prev parent reply other threads:[~2021-08-27 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 15:22 [Intel-gfx] [PATCH 1/4] drm/i915/runtime_pm: Consolidate runtime_pm functions Rodrigo Vivi
2021-08-25 15:22 ` [Intel-gfx] [PATCH 2/4] drm/i915: Disallow D3Cold Rodrigo Vivi
2021-08-27 16:58 ` Imre Deak
2021-08-25 15:22 ` [Intel-gfx] [PATCH 3/4] drm/i915: Enable runtime pm autosuspend by default Rodrigo Vivi
2021-08-27 13:08 ` Gupta, Anshuman
2021-08-25 15:22 ` [Intel-gfx] [PATCH 4/4] drm/i915/runtime_pm: Reduce autosuspend delay to 1s Rodrigo Vivi
2021-08-27 10:54 ` Gupta, Anshuman [this message]
2021-08-25 20:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/runtime_pm: Consolidate runtime_pm functions Patchwork
2021-08-25 21:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-08-27 16:31 ` [Intel-gfx] [PATCH 1/4] " Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8a18298e46c43a49da7369fba92ca99@intel.com \
--to=anshuman.gupta@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tilak.tangudu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.