Re: [PATCH nf v6 0/6] ipset: replace internal hash table with rhashtable

[Jozsef Kadlecsik <kadlec@netfilter.org>]

Hi Florian,

I'm absolutely sure that your efforts to replace the custom hash 
implementation in ipset with rhastable is the proper way to solve the many 
problems lurking in the current codebase. Which are sometimes nearly 
impossible to solve anyway, without a complete redesign. So looking at the 
sashiko comments, I think the end of the long journey is not far away!

Best regards,
Jozsef

On Tue, 27 Oct 2026, Florian Westphal wrote:

> v6: address more AI complaints on v5, affects patches 3, 4 and 5.
> Rest unchanged.
> 
> v5: add Herbert Xu's new rhashtable_flush_and_free() to rhashtable, this
> replaces my own version from v4.  I also dropped a few follwup patches
> with further changes/cleanups, not strictly required for initial
> conversion.
> 
> 1) Add rhashtable_flush_and_free, From Herbert Xu.
> The initial user of this function is added in patch 4.
> 
> 2) Add rhashtable boilerplate stubs to ipset. Implement its initialization
> and destruction logic.
> 
> 3) Add rhltable boilerplate stubs to netfilter ipset. Prepare for handling
> distinct elements sharing the same hash key.
> 
> 4) Replace ipset internal hash tables with rhashtables.
> Retain legacy configuration options.
> 
> 5) Restore SET_WITH_FORCEADD eviction support to netfilter ipset. Add
> mtype_remove_random() helper to facilitate element eviction during
> additions.
> 
> 6) Report dynamic CIDR storage memory size to userspace.
> 
> Florian Westphal (5):
>   netfilter: ipset: add rhashtable boilerplate stubs
>   netfilter: ipset: add rhltable boilerplate stubs
>   netfilter: ipset: replace internal hash table with rhashtable
>   netfilter: ipset: re-add forceadd support
>   netfilter: ipset: also report mem size for cidr storage to userspace
> 
> Herbert Xu (1):
>   rhashtable: Add rhashtable_flush_and_free helper
> 
>  include/linux/rhashtable.h                 |   40 +-
>  lib/rhashtable.c                           |  187 ++-
>  net/netfilter/ipset/ip_set_hash_gen.h      | 1638 ++++++++------------
>  net/netfilter/ipset/ip_set_hash_netiface.c |   24 +-
>  4 files changed, 860 insertions(+), 1029 deletions(-)
> 
> -- 
> 2.55.0
> 
> 

-- 
E-mail : kadlec@netfilter.org, kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
Address: Wigner Research Centre for Physics
         H-1525 Budapest 114, POB. 49, Hungary