From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C81C54E58 for ; Mon, 11 Mar 2024 12:07:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.691440.1077415 (Exim 4.92) (envelope-from ) id 1rjeQr-0002V2-Di; Mon, 11 Mar 2024 12:07:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 691440.1077415; Mon, 11 Mar 2024 12:07:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rjeQr-0002Uv-B1; Mon, 11 Mar 2024 12:07:05 +0000 Received: by outflank-mailman (input) for mailman id 691440; Mon, 11 Mar 2024 12:07:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rjeQq-0002Up-30 for xen-devel@lists.xenproject.org; Mon, 11 Mar 2024 12:07:04 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df1fe9bf-df9f-11ee-afdc-a90da7624cb6; Mon, 11 Mar 2024 13:07:03 +0100 (CET) Received: from [192.168.1.9] (net-93-144-106-196.cust.vodafonedsl.it [93.144.106.196]) by support.bugseng.com (Postfix) with ESMTPSA id 6CACA4EE0C90; Mon, 11 Mar 2024 13:07:02 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df1fe9bf-df9f-11ee-afdc-a90da7624cb6 Message-ID: Date: Mon, 11 Mar 2024 13:07:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v3 04/16] xen/arm: address violations of MISRA C:2012 Directive 4.10 Content-Language: en-US To: Jan Beulich Cc: consulting@bugseng.com, sstabellini@kernel.org, Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Maria Celeste Cesario , xen-devel@lists.xenproject.org References: <868ede5a23489e018e272188edfbee572d1ad393.1710145041.git.simone.ballarin@bugseng.com> <332ebf49-9aa4-42fd-99be-bda16580c92f@suse.com> From: Simone Ballarin Organization: BUGSENG In-Reply-To: <332ebf49-9aa4-42fd-99be-bda16580c92f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/03/24 11:10, Jan Beulich wrote: > On 11.03.2024 09:59, Simone Ballarin wrote: >> --- a/xen/arch/arm/efi/efi-boot.h >> +++ b/xen/arch/arm/efi/efi-boot.h >> @@ -3,6 +3,10 @@ >> * is intended to be included by common/efi/boot.c _only_, and >> * therefore can define arch specific global variables. >> */ >> + >> +#ifndef XEN_ARCH_ARM_EFI_EFI_BOOT_H >> +#define XEN_ARCH_ARM_EFI_EFI_BOOT_H > > Related to my question raised against the cover letter, what does the > XEN_ prefix gain us here? All building of the hypervisor binaries > happens inside the xen/ subtree. > > Jan what do you thing about adding this rule: arch/// -> ___H ? -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com)