From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C355C433EF for ; Tue, 2 Nov 2021 10:50:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0E0560EE9 for ; Tue, 2 Nov 2021 10:50:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0E0560EE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 13D6083601; Tue, 2 Nov 2021 11:50:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1635850229; bh=FVtrSyMvTnIm3EoPzwXpIs2D1Ph0Ufyw9iyydMZwA8M=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vpkfGmbjo38HgrPh+n8k7OGGz8Ho2I8Iv8yN7GS+B4IYiEXUsXMQ2WCALFfg2eGGT jdhMJcyTSGI97JbfchDY/ArUMCirymrJr+n9xwGw9dIhZ04CPBs/lmvjvs5YKO9mi5 sDyP6waxSSDCyZgypnx53000isicGBEsRXA3znC9+NGsbNcv7/JmU4GCoxnYFl9/U3 pEjPSDKt0N1vKmhQVd9kfwM1GkRGV7Aw1tEqXBIO1N6vXQZ+3b+P8IiWILeIUw8INt 4pUYkBDLGY+uQun1or18JyUtRUX4Tl23f9eq8JxdcxFUpyeS2Dqg1bOP7NztGZYi80 F4SrixYGDKWYQ== Received: by phobos.denx.de (Postfix, from userid 109) id 08A988360D; Tue, 2 Nov 2021 11:50:27 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B65388119C for ; Tue, 2 Nov 2021 11:50:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (unknown [91.198.250.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4Hk6B64StLzQjPn; Tue, 2 Nov 2021 11:50:22 +0100 (CET) Subject: Re: [PATCH 6/8] pci: pci_mvebu: Do not automatically enable bus mastering on PCI Bridge To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de References: <20211022142215.26484-1-pali@kernel.org> <20211022142215.26484-7-pali@kernel.org> From: Stefan Roese Message-ID: Date: Tue, 2 Nov 2021 11:50:18 +0100 MIME-Version: 1.0 In-Reply-To: <20211022142215.26484-7-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5003A26B X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 22.10.21 16:22, Pali Rohár wrote: > Now that PCI Bridge is working, U-Boot's CONFIG_PCI_PNP code automatically > enables memory access and bus mastering when it is needed. So do not > prematurely enable memory access and bus mastering. > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/pci/pci_mvebu.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c > index 40b8a57bbe1e..e43fa12d3819 100644 > --- a/drivers/pci/pci_mvebu.c > +++ b/drivers/pci/pci_mvebu.c > @@ -451,14 +451,6 @@ static int mvebu_pcie_probe(struct udevice *dev) > /* Setup windows and configure host bridge */ > mvebu_pcie_setup_wins(pcie); > > - /* Master + slave enable. */ > - reg = readl(pcie->base + PCIE_CMD_OFF); > - reg |= PCI_COMMAND_MEMORY; > - reg |= PCI_COMMAND_IO; > - reg |= PCI_COMMAND_MASTER; > - reg |= BIT(10); /* disable interrupts */ > - writel(reg, pcie->base + PCIE_CMD_OFF); > - > /* PCI memory space */ > pci_set_region(hose->regions + 0, pcie->mem.start, > pcie->mem.start, PCIE_MEM_SIZE, PCI_REGION_MEM); > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de