From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] net/bonding: fix reset active slave Date: Wed, 20 Feb 2019 12:33:09 +0000 Message-ID: References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "Pattan, Reshma" , JananeeX M , Declan , stable@dpdk.org, Hyong Youb Kim To: Radu Nicolau , Hari Kumar Vemula , dev@dpdk.org Return-path: In-Reply-To: <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/18/2019 3:58 PM, Radu Nicolau wrote: > > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: >> test_alb_reply_from_client test fails due to incorrect active slave >> array's index. This was due to invalid active slave count. >> >> Count of internals->active_slave is not updated even when active slave >> is deactivated. >> Hence active slave count always keeps incrementing beyond the actual >> active slaves. >> >> Fix is to set the internals->active_slave to starting index 0 whenever >> it exceeds the number of slaves in active slave list and also update >> the active slave count during slave de-activation. >> >> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") >> Cc: stable@dpdk.org >> >> Signed-off-by: Hari Kumar Vemula >> --- >> > Acked-by: Radu Nicolau > Hi Radu, Hari, There is another bonding patch, can you please check how related are they and if are these fixing same root cause: net/bonding: avoid the next active slave going out of bound https://patches.dpdk.org/patch/49573/