From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbcBWAhT (ORCPT ); Mon, 22 Feb 2016 19:37:19 -0500 Received: from mail.tnode.com ([46.54.226.45]:47807 "EHLO mail.tnode.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755859AbcBWAhQ (ORCPT ); Mon, 22 Feb 2016 19:37:16 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 23 Feb 2016 00:37:14 +0000 From: Andrej Krpic To: Joe Perches Cc: , , Subject: Re: [PATCH 1/8] tty: =?UTF-8?Q?n=5Fgsm=3A=20fix=20formatting=20er?= =?UTF-8?Q?rors?= In-Reply-To: <1456093820.31061.7.camel@perches.com> References: <1456090717-19913-1-git-send-email-ak77@tnode.com> <1456090717-19913-2-git-send-email-ak77@tnode.com> <1456093820.31061.7.camel@perches.com> Message-ID: User-Agent: Roundcube Webmail Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.02.2016 22:30, Joe Perches wrote: > On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote: >> Minor formatting changes to remove errors and reduce number of >> warnings produced by checkpatch.pl script. > [] >> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c > [] >> @@ -489,7 +490,8 @@ static void gsm_print_packet(const char *hdr, >> int addr, int cr, >>   if (!(control & 0x01)) { >>   pr_cont("I N(S)%d N(R)%d", >>   (control & 0x0E) >> 1, (control & 0xE0) >> 5); >> - } else switch (control & 0x0F) { >> + } else >> + switch (control & 0x0F) { > > Please follow the brace rule for else uses where > if one branch has braces, the other does too. Thank you for noticing. Should I resend this as a single patch or wait for more comments for v2 series? -Andrej