All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: vsementsov@virtuozzo.com, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, armbru@redhat.com,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	den@openvz.org
Subject: Re: [PATCH v3 0/3] Dump QCOW2 metadata
Date: Sat, 22 Feb 2020 07:09:00 -0600	[thread overview]
Message-ID: <a8f04995-e90b-e7f1-ee39-04ffccc843ae@redhat.com> (raw)
In-Reply-To: <20200220122806.GC5932@linux.fritz.box>

On 2/20/20 6:28 AM, Kevin Wolf wrote:
> Am 20.02.2020 um 12:58 hat Max Reitz geschrieben:
>> On 14.01.20 09:22, Andrey Shinkevich wrote:
>>> The information about QCOW2 metadata allocations in an image ELF-file is
>>> helpful for finding issues with the image data integrity.
>>
>> Sorry that I’m replying only so late – but I don’t know why we need this
>> in qemu, and this cover letter doesn’t provide a justification.  I mean,
>> it isn’t too complex (from the diffstat), but wouldn’t it be better to
>> just have a script for this?
> 
> Specifically, we could extend tests/qemu-iotests/qcow2.py. This seems to
> be debugging output that would be in line with what the script is
> already used for.

I also just discovered GNU poke, http://jemarch.net/poke, which is an 
arbitrary binary-format editor with a fairly good example of how it can 
be used to inspect ELF files.  I'm wondering if it would be easier to 
write a pickle describing the qcow2 format that would make it easier to 
do interactive browsing/editing of a qcow2 file, at the expense of 
having to depend on poke (which has not yet hit the 1.0 release and is 
not yet bundled for Fedora).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



      reply	other threads:[~2020-02-22 13:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14  8:22 [PATCH v3 0/3] Dump QCOW2 metadata Andrey Shinkevich
2020-01-14  8:22 ` [PATCH v3 1/3] qcow2: introduce Qcow2Metadata structure Andrey Shinkevich
2020-01-17 16:06   ` Vladimir Sementsov-Ogievskiy
2020-01-14  8:22 ` [PATCH v3 2/3] qemu-img: sort key options alphabetically Andrey Shinkevich
2020-01-14  8:22 ` [PATCH v3 3/3] qcow2: dump QCOW2 metadata Andrey Shinkevich
2020-02-20 11:58 ` [PATCH v3 0/3] Dump " Max Reitz
2020-02-20 12:10   ` Vladimir Sementsov-Ogievskiy
2020-02-25 16:16     ` Max Reitz
2020-02-20 12:28   ` Kevin Wolf
2020-02-22 13:09     ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8f04995-e90b-e7f1-ee39-04ffccc843ae@redhat.com \
    --to=eblake@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.