From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: zyjzyj2000@gmail.com, leon@kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/rxe: Make pr_fmt work
Date: Wed, 27 Mar 2024 20:40:54 +0100 [thread overview]
Message-ID: <a9011ab4-6947-4ad4-8d1f-653e129c38b9@linux.dev> (raw)
In-Reply-To: <20240327130804.GH8419@ziepe.ca>
在 2024/3/27 14:08, Jason Gunthorpe 写道:
> On Sat, Mar 23, 2024 at 09:31:39AM +0100, Yanjun.Zhu wrote:
>> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>>
>> If the definition of pr_fmt is before the header file. The pr_fmt
>> will be overwritten by the header file. So move the definition of
>> pr_fmt to the below of the header file.
> what header file?
include/linux/printk.h
Because this driver will finally call printk function to output the
logs, the header file include/linux/printk.h needs be included.
In include/linux/printk.h, pr_fmt is defined.
I made a simple checks. In about 130 header files, this pr_fmt is defined.
Zhu Yanjun
>
> Jason
next prev parent reply other threads:[~2024-03-27 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 8:31 [PATCH 1/1] RDMA/rxe: Make pr_fmt work Yanjun.Zhu
2024-03-24 11:43 ` Greg Sword
2024-03-27 13:08 ` Jason Gunthorpe
2024-03-27 19:40 ` Zhu Yanjun [this message]
2024-04-04 14:59 ` Jason Gunthorpe
[not found] ` <7a2a41c2-c8ef-402d-933a-2b2d8a956207@linux.dev>
2024-04-04 18:03 ` Zhu Yanjun
2024-04-04 23:59 ` Jason Gunthorpe
2024-04-06 16:35 ` Zhu Yanjun
2024-04-08 14:08 ` Jason Gunthorpe
2024-04-02 17:45 ` Leon Romanovsky
2024-04-03 16:46 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9011ab4-6947-4ad4-8d1f-653e129c38b9@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.