All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shekhar Chauhan <shekhar.chauhan@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
	<intel-xe@lists.freedesktop.org>, <harish.chegondi@intel.com>
Subject: Re: [PATCH v8 1/8] drm/xe/oa: Ignore a HW tail pointer outside the OA buffer
Date: Fri, 20 Nov 2026 12:51:46 +0530	[thread overview]
Message-ID: <a92cf949-2f2c-472d-9161-d948e8b7244a@intel.com> (raw)
In-Reply-To: <20261119002737.3899877-11-umesh.nerlige.ramappa@intel.com>


On 11/19/2026 5:57, Umesh Nerlige Ramappa wrote:
> A device that stopped responding, e.g. during PCI error recovery or
> after a surprise removal, returns all ones for the OA tail pointer, and
> a reset device returns 0. Subtracting the GGTT address of the OA buffer
> then leaves a tail offset way past the end of the OA buffer.
>
> Since xe_oa_circ_diff() replaced the masked OA_TAKEN(), nothing brings
> such an offset back into the OA buffer. xe_oa_buffer_check_unlocked()
> walks backward from it, reading report ids and timestamps out of bounds
> of the OA buffer mapping, from the poll hrtimer in hardirq context and
> with the OA buffer lock held.
>
> Ignore a HW tail outside the OA buffer, as if no new reports landed.
>
> Fixes: 3a1fc394ba85 ("drm/xe/oa: Changes to OA_TAKEN")
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

I am unsure about the Fixes tag cause of the Sashiko comment below, but 
apart from it, everything LGTM, and with that,

Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_oa.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 838802482ada..fdd2d11ce4e7 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -270,6 +270,15 @@ static bool xe_oa_buffer_check_unlocked(struct xe_oa_stream *stream)
>   	hw_tail = xe_oa_hw_tail_read(stream);
>   	hw_tail -= gtt_offset;
>   
> +	/*
> +	 * A device that stopped responding, or was reset, returns a tail outside the OA
> +	 * buffer. Don't walk the buffer from there.
> +	 */
> +	if (hw_tail >= stream->oa_buffer.circ_size) {
> +		spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
> +		return false;
> +	}
> +
>   	/*
>   	 * The tail pointer increases in 64 byte (cacheline size), not in report_size
>   	 * increments. Also report size may not be a power of 2. Compute potential

-- 
Shekhar Chauhan
Linux Graphics Software Engineer
Linux Platform Enabling
Intel Corporation


  parent reply	other threads:[~2026-11-20  7:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  0:27 [PATCH v8 0/8] Cleanup OA stream on PCI unbind/remove Umesh Nerlige Ramappa
2026-11-19  0:27 ` [PATCH v8 1/8] drm/xe/oa: Ignore a HW tail pointer outside the OA buffer Umesh Nerlige Ramappa
2026-11-19  0:39   ` sashiko-bot
2026-11-20 20:14     ` Umesh Nerlige Ramappa
2026-11-20  7:21   ` Shekhar Chauhan [this message]
2026-11-20 20:07     ` Umesh Nerlige Ramappa
2026-11-19  0:27 ` [PATCH v8 2/8] drm/xe/oa: Use the drm device address_space for the OA stream fd Umesh Nerlige Ramappa
2026-11-19  0:39   ` sashiko-bot
2026-11-20  7:23   ` Shekhar Chauhan
2026-11-19  0:27 ` [PATCH v8 3/8] drm/xe/oa: Wait for in-flight OA batches before stream HW teardown Umesh Nerlige Ramappa
2026-11-20  7:24   ` Shekhar Chauhan
2026-11-19  0:27 ` [PATCH v8 4/8] drm/xe: Reject vm_ops->access on BO mappings of an unplugged device Umesh Nerlige Ramappa
2026-11-19  0:39   ` sashiko-bot
2026-11-19 22:36   ` Matthew Brost
2026-11-19  0:27 ` [PATCH v8 5/8] drm/xe/oa: Fence OA ioctls and mmap against device unplug and wedging Umesh Nerlige Ramappa
2026-11-20  7:25   ` Shekhar Chauhan
2026-11-19  0:27 ` [PATCH v8 6/8] drm/xe/oa: Take the runtime PM reference in xe_oa_destroy_locked() Umesh Nerlige Ramappa
2026-11-20  7:27   ` Shekhar Chauhan
2026-11-19  0:27 ` [PATCH v8 7/8] drm/xe/oa: Free the OA buffer and the stream after the stream destroy Umesh Nerlige Ramappa
2026-11-19  0:48   ` sashiko-bot
2026-11-20  7:29   ` Shekhar Chauhan
2026-11-19  0:27 ` [PATCH v8 8/8] drm/xe/oa: Quiesce OA streams on driver unbind and PCI reset Umesh Nerlige Ramappa
2026-11-19  1:11   ` sashiko-bot
2026-11-20  7:31     ` Shekhar Chauhan
2026-11-19  6:05 ` ✓ CI.KUnit: success for Cleanup OA stream on PCI unbind/remove (rev8) Patchwork
2026-11-19  6:46 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-20  9:31 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a92cf949-2f2c-472d-9161-d948e8b7244a@intel.com \
    --to=shekhar.chauhan@intel.com \
    --cc=harish.chegondi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.