All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
To: "Tauro, Riana" <riana.tauro@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests/i915/i915_pm_rc6_residency: Use correct type for power in rc6-fence
Date: Mon, 11 Jul 2022 13:27:27 +0000	[thread overview]
Message-ID: <a937afd2f5c84f0996a6cd11b631346c@intel.com> (raw)
In-Reply-To: <20220711085214.359128-2-riana.tauro@intel.com>



> -----Original Message-----
> From: Tauro, Riana <riana.tauro@intel.com>
> Sent: Monday, July 11, 2022 2:22 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Tauro, Riana <riana.tauro@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>
> Subject: [PATCH i-g-t 1/1] tests/i915/i915_pm_rc6_residency: Use correct type
> for power in rc6-fence
> 
> Use the correct type in rc6-fence for power to prevent truncating value to 0.
> 
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
LGTM.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_rc6_residency.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_rc6_residency.c
> b/tests/i915/i915_pm_rc6_residency.c
> index 67d25918..cf7a92b9 100644
> --- a/tests/i915/i915_pm_rc6_residency.c
> +++ b/tests/i915/i915_pm_rc6_residency.c
> @@ -509,7 +509,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
>  		igt_debug("%s: slept=%lu perf=%"PRIu64", rc6=%"PRIu64"\n",
>  			  e->name, slept, ts[1] - ts[0], rc6);
>  		if (rapl_read(&rapl, &sample[1]))  {
> -			uint64_t power = power_J(&rapl, &sample[0],
> &sample[1]);
> +			double power = power_J(&rapl, &sample[0],
> &sample[1]);
>  			igt_info("Total energy used for %s: %.1fmJ
> (%.1fmW)\n",
>  				 e->name,
>  				 power * 1e3,
> --
> 2.25.1

  reply	other threads:[~2022-07-11 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11  8:52 [igt-dev] [PATCH i-g-t 0/1] Use the correct type for power in rc6-fence Riana Tauro
2022-07-11  8:52 ` [igt-dev] [PATCH i-g-t 1/1] tests/i915/i915_pm_rc6_residency: Use " Riana Tauro
2022-07-11 13:27   ` Gupta, Anshuman [this message]
2022-07-11  9:38 ` [igt-dev] ✓ Fi.CI.BAT: success for Use the " Patchwork
2022-07-11 11:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a937afd2f5c84f0996a6cd11b631346c@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=riana.tauro@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.