From: Remy Horton <remy.horton@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, thomas.monjalon@6wind.com
Cc: stable@dpdk.org
Subject: Re: [PATCH 1/2] ethdev: fix name index in xstats Api
Date: Tue, 3 Jan 2017 10:03:52 +0000 [thread overview]
Message-ID: <a947027c-ae18-1d72-78bf-d26e9cddac50@intel.com> (raw)
In-Reply-To: <1481881454-17382-1-git-send-email-olivier.matz@6wind.com>
Been away, hence the somewhat late review..
On 16/12/2016 09:44, Olivier Matz wrote:
[..]
> Today, each 'id' returned by rte_eth_xstats_get() is equal to the index
> in the returned array, making this value useless. It also prevents a
> driver from having different indexes for names and value, like in the
> example below:
My original intention was to give free reign over what id numbers are
used, but for reasons I've now forgotten the implementation ended up
making everything sequential.
> CC: stable@dpdk.org
> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Remy Horton <remy.horton@intel.com>
prev parent reply other threads:[~2017-01-03 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 9:44 [PATCH 1/2] ethdev: fix name index in xstats Api Olivier Matz
2016-12-16 9:44 ` [PATCH 2/2] ethdev: clarify xstats Api documentation Olivier Matz
2016-12-16 14:28 ` [dpdk-stable] " Mcnamara, John
2016-12-16 14:36 ` Olivier Matz
2016-12-23 20:35 ` [PATCH v2 " Olivier Matz
2017-01-03 10:03 ` Remy Horton
2017-01-04 18:10 ` Thomas Monjalon
2017-01-03 10:03 ` Remy Horton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a947027c-ae18-1d72-78bf-d26e9cddac50@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.