From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B551EC43463 for ; Fri, 18 Sep 2020 17:47:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7884821707 for ; Fri, 18 Sep 2020 17:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgIRRrx (ORCPT ); Fri, 18 Sep 2020 13:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgIRRrx (ORCPT ); Fri, 18 Sep 2020 13:47:53 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77774C0613CE for ; Fri, 18 Sep 2020 10:47:53 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kJKUB-006Oy8-PI; Fri, 18 Sep 2020 19:47:51 +0200 Message-ID: Subject: Re: [PATCH v3 04/22] nl80211: correctly validate S1G beacon head From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless Date: Fri, 18 Sep 2020 19:47:49 +0200 In-Reply-To: <97924cf65e6806fd896ada049f3d46ea@adapt-ip.com> References: <20200908190323.15814-1-thomas@adapt-ip.com> <20200908190323.15814-5-thomas@adapt-ip.com> <8b7f1ab8a15a06a23b7db2fb120e3144c482d7b9.camel@sipsolutions.net> <97924cf65e6806fd896ada049f3d46ea@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2020-09-18 at 10:45 -0700, Thomas Pedersen wrote: > On 2020-09-18 03:56, Johannes Berg wrote: > > On Tue, 2020-09-08 at 12:03 -0700, Thomas Pedersen wrote: > > > The S1G beacon has a different header size than regular > > > beacons, so adjust the beacon head validator. > > > > I've applied this already and will keep it, but you later add short > > beacons - don't they need further adjustments here too? > > Yes, but I was planning on doing that in the (yet to be submitted) "add > S1G short beacon support" patch. OK, fair enough, was just wondering :) johannes