From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC9CC433EF for ; Wed, 6 Jul 2022 07:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbiGFHjw (ORCPT ); Wed, 6 Jul 2022 03:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiGFHjv (ORCPT ); Wed, 6 Jul 2022 03:39:51 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D536C20BFF for ; Wed, 6 Jul 2022 00:39:50 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id d12so1122468lfq.12 for ; Wed, 06 Jul 2022 00:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jzG6QZoUKUUCK3YJZk4MEFjI5YySlhPEGKUbTo7RTJQ=; b=qtm/o99kgw+UoKiprAAZuaIa7H1m7ozgfqwYYN14ugBR8iGxj7uyeoRa89wr+kyHcs yHEkD428fJeYXjPsK+weye1UZIyOMFycw1djUqXJ1OTtfZs8UnOc+9sGFNz/xaZz3Wra 7WrWKBd1fDPQHSWLMWYpQSLCpIbdIURjU1erlAxqpQ1rl3xjPEwiKli8vfcycAGrjTy5 G5BCFeRh2rlSU3uWQs1k/6MoZqyTbfQqE9TZUjNYZQ0DOxjev/5pGW1NIDH7sVqrpgiN dSkqDrhRwtXgzzmvXN9SyZqQxAuHVm71Wwm5k9pEBMj3NpaoJgm5YkNG6JmZcx2JdU9b eFPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jzG6QZoUKUUCK3YJZk4MEFjI5YySlhPEGKUbTo7RTJQ=; b=AlNvvp/t+QXfSr38uFynVw0XK1BR2dZPerMT9WM0guOkC8zbK4CLzgptHNCWaoA8oH mlQO7q026JkP98byQOHl2xI+E668cnu1SMLJH1pFsF+p2Qdq8+1zzNN2vfntlw95/u3P gvmqPtleCwtOruxXxpGeFZgdIZSwPQTByanhCDGmYCwK+wgf5ZwVDaeoa41YkwMdClAZ vR6HTa731Ww6w3XN2wdhdxEyrWQZbJFcufbLwIeQofxeFq/v8OkqXWqbJzOEqumjSJRr 4JyD8Ul8+4Dh9Y7DpI+PqrKZkcqN5ipAclLEYaR6RjBiC+8q5wlKbw1xPYFgJsGeip1/ /XoQ== X-Gm-Message-State: AJIora9dIFHPKwzrxCb2Dp8hjNLpcsFK/CLxFX1Qipb2VOtStXeOJLH5 XMFmGpwlNzVgYu5CMqmHs2zofQ== X-Google-Smtp-Source: AGRyM1ve0SZz0cJw8tLNtrftpPA78sfQOumel7lPFe1C9DExiRSJCU1az4fghWw0JnlGscURVh2ZOA== X-Received: by 2002:a05:6512:23aa:b0:481:21c7:2e2f with SMTP id c42-20020a05651223aa00b0048121c72e2fmr25825147lfv.458.1657093189253; Wed, 06 Jul 2022 00:39:49 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id u11-20020ac258cb000000b004811ee59f40sm4648263lfo.276.2022.07.06.00.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 00:39:48 -0700 (PDT) Message-ID: Date: Wed, 6 Jul 2022 09:39:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH net-next v2 5/9] dt-bindings: net: Add Tegra234 MGBE Content-Language: en-US To: Bhadram Varka , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com, jonathanh@nvidia.com, kuba@kernel.org, catalin.marinas@arm.com, will@kernel.org, pabeni@redhat.com, davem@davemloft.net, edumazet@google.com References: <20220706031259.53746-1-vbhadram@nvidia.com> <20220706031259.53746-6-vbhadram@nvidia.com> From: Krzysztof Kozlowski In-Reply-To: <20220706031259.53746-6-vbhadram@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 06/07/2022 05:12, Bhadram Varka wrote: > Add device-tree binding documentation for the Tegra234 MGBE ethernet > controller. > > Signed-off-by: Jon Hunter > Signed-off-by: Bhadram Varka > --- > .../bindings/net/nvidia,tegra234-mgbe.yaml | 167 ++++++++++++++++++ > 1 file changed, 167 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml > > diff --git a/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml > new file mode 100644 > index 000000000000..1a45cd374b19 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml > @@ -0,0 +1,167 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra234 MGBE Device Tree Bindings Either you agree with a comment/feedback or you answer and we keep discussion going. Ignoring a comment is a no-go. Please fix everything what Rob pointed out. > + > +maintainers: > + - Thierry Reding > + - Jon Hunter > + > +properties: > + > + compatible: > + const: nvidia,tegra234-mgbe > + > + reg: > + minItems: 3 > + maxItems: 3 > + > + reg-names: > + items: > + - const: hypervisor > + - const: mac > + - const: xpcs > + > + interrupts: > + minItems: 1 > + > + interrupt-names: > + items: > + - const: common NAK. Best regards, Krzysztof